Segfault because of unsanitazed function parameters about edlib HOT 5 OPEN

Ah yes, good catch, thanks! I didnt do validation of input parameters yet, but I should certainly do it.
I usually do not check if malloc pointer is NULL, how likely is that to happen? Is that something that is usually handled?

from edlib.

This one will be handled by #38

from edlib.

I usually do not check if malloc pointer is NULL, how likely is that to happen?

I think it is always a good practice, though if you are allocating small chunks of memory it is very unlikely you won't be able to actually get it. But since your library could potentially consume huge amounts of space, I think it would be prudent.

E.g. As from one of the previous examples I've sent you, even on relatively small input sizes (e.g. query sequence of length 30k) the memory consumption gets up to 100MB if alignment reconstruction was requested. Imagine if I was to run it with even a larger query sequence, and perform that in parallel on several cores. I feel you could get in the ball park of available free memory on a normal (not very-high end) laptop.

from edlib.

That is true! Ok, I will certainly takecare of that at some moment soon,
thanks
On Feb 8, 2015 8:41 AM, "Ivan Sovic" [email protected] wrote:

I usually do not check if malloc pointer is NULL, how likely is that to
happen?

I think it is always a good practice, though if you are allocating small
chunks of memory it is very unlikely you won't be able to actually get it.
But since your library could potentially consume huge amounts of space, I
think it would be prudent.

E.g. As from one of the previous examples I've sent you, even on
relatively small input sizes (e.g. query sequence of length 30k) the
memory consumption gets up to 100MB if alignment reconstruction was
requested. Imagine if I was to run it with even a larger query sequence,
and perform that in parallel on several cores. I feel you could get in the
ball park of available free memory on a normal (not very-high end) laptop.

—
Reply to this email directly or view it on GitHub
#37 (comment).

from edlib.

Note: checking if memory was allocated is not such a big issue anymore, since we do not consumer large amount of memory any more (thanks to hirschbergs algorithm).

from edlib.