Directories created with `testza.SnapshotCreateOrValidate` do not have execute permissions set about testza HOT 6 CLOSED

HTH. I'm enjoying the library: great output, and the snapshot functions are really useful. Thanks!

from testza.

Hi @jamestelfer, I cannot reproduce it with my machine. But you're totally right, that the permission should be changed to be equal to the others. I will, most likely, push a release today, that includes this fix. It would be kind if you could report if it works then!

And thanks for the compliment! 😄

from testza.

No worries and thanks! I will definitely check it out.

I can only reproduce it when the snapshots are first created and there's no existing directory. I'm not sure either whether it's impacted by my use of t.Run() and t.Name() with a data driven test, which increases the levels of directory nesting.

I looked at creating a test case and a PR but I wasn't sure how to try to get the snapshots to be sourced from a separate folder. I can't say that I looked deeply at it though (sorry).

This was occurring for me on a Mac, haven't tried any other systems.

from testza.

OK I have a minimal repro:

func TestSnapshots(t *testing.T) {
	cases := []struct {
		name string
	}{
		{
			name: "nested-name",
		},
	}

	for _, c := range cases {
		t.Run(c.name, func(t *testing.T) {
			// this should fail as the snapshot file can't be written to the directory that doesn't exist
			err := testza.SnapshotCreateOrValidate(t, t.Name(), "flamingos are pink")
			testza.AssertNoError(t, err)
		})
	}
}

Let me see if I can get a failing test case out of this.

from testza.

That should do the trick, but feel free to change the test in whatever way you see fit. I had a linter issue that I've come across at work a few times, so hopefully #109 will fix that too.

Thanks for the project!

from testza.

Hi @jamestelfer, thanks for the PR! I am currently looking into it, and it looks good.

from testza.