Giter VIP home page Giter VIP logo

Comments (2)

Marwes avatar Marwes commented on June 14, 2024

The reason for the Clone bound is that combine assumes that Stream is a type that can be cloned (which is necessary for the or parser which implements alternation). Since Stream can be cloned it follows that its tokens must be cloneable as well (any token that does not implement Clone could still be duplicated by cloning the stream stream.uncons().clone() vs stream.clone().uncons() so there is no reason that they would not be possible to clone). If we then also assume that streams and tokens are cheap to clone (if they were expensive to clone then parsing would be slow) then it follows that the predicates might as well take Item instead of &Item as it is much more convenient in common cases such as Item = u8 or Item = char.

That was my reasoning in any case :).

As for the lifetime problem, that is not something I had considered actually. I can't think of anyway to make token available for that case as the token requires exactly the Item type since that is used to construct the error message if the parser fails

error.errors.push(Error::Expected(Info::Token(self.c.clone())));
. Using the the satisfy parser instead should work though.

from combine.

Marwes avatar Marwes commented on June 14, 2024

Reasoning for Copy #44

from combine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.