Giter VIP home page Giter VIP logo

Comments (6)

snelsi avatar snelsi commented on June 12, 2024 1

react-resize-detector v10 has been developed and tested with React 18, and therefore, it's reasonable for the package to set React 18+ as a peer dependency. Users who need compatibility with React 16 can either choose to ignore the recommended peerDependencies or stick with the previous version of the package (v9.1.1), which is compatible with React 16.

from react-resize-detector.

shannonhochkins avatar shannonhochkins commented on June 12, 2024 1

That doesn't answer my question about it being a breaking change, and you do keep repeating yourself, I understand that you've said it works with 18 and it's tested with 18, as i said in my first request, there's absolutely nothing in the code that suggests that it should be fixed to 18, you're excluding an entire user base who are stuck with older versions of react, i would normally agree with you if this was a complicated intricate piece of software, but it's not, it's a very simple hook using vanilla javascript features wrapped in a hook....

from react-resize-detector.

snelsi avatar snelsi commented on June 12, 2024

React versions before 18 are considered legacy at this point. Compatibility with them is not guaranteed.
We dropped support for previous versions of React to provide long-term stability and maintenance for react-resize-detector v10.

You can stay on the latest react-resize-detector v9 release until you can migrate your application to React 18:

from react-resize-detector.

shannonhochkins avatar shannonhochkins commented on June 12, 2024

You can always drop ongoing support without raising the peer dependency requirements? As mentioned, that isn't how you manage support, simply mention it rather than enforce it

from react-resize-detector.

snelsi avatar snelsi commented on June 12, 2024

Updating peer dependencies is a breaking change and requires a major version bump.
react-resize-detector v10 only guarantees support with React v18+.
If you need support for React 16 you can either ignore the recommended peerDependencies or downgrade to react-resize-detector v9.1.1

from react-resize-detector.

shannonhochkins avatar shannonhochkins commented on June 12, 2024

How is it a breaking change? curious why you're saying that? Peer dependencies are determined or installed by npm or manually with yarn, don't understand why you say it's a breaking change?

from react-resize-detector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.