Invalid backslash in uploaded json about yet-another-bench-script HOT 6 CLOSED

Yes, I've only seen it in the isp and asn fields but I assume all of the ip_info section is susceptible of including those backslashes. I suppose the backslash could also be found in cpu models since VPS providers can set it any way they want.
Thanks for taking the time to fix this!

from yet-another-bench-script.

Appreciate the bug report! Should be easy to filter out the backslashes. Has the network details section been the only area you have been receiving backslashes? I don't think any other field would be susceptible to bad input, but I want to confirm before implementing a change.

from yet-another-bench-script.

I just realized that ip-api.com returns json like this in those cases:

{
    "as": "AS44486 Oliver Horscht is trading as \"SYNLINQ\"",
    "city": "Frankfurt am Main",
    "country": "Germany",
    "countryCode": "DE",
    "isp": "Oliver Horscht is trading as \"SYNLINQ\"",
    "lat": 50.1109,
    "lon": 8.68213,
    "org": "Solutions Virfect",
    "query": "103.252.88.1",
    "region": "HE",
    "regionName": "Hesse",
    "status": "success",
    "timezone": "Europe/Berlin",
    "zip": "60313"
}

So yabs.sh must be removing the " but keeping the \. It should either keep them both (ip-api.com returns valid json after all, there might be no need to alter those strings) or remove them both

from yet-another-bench-script.

Just pushed some changes (52f048b) to fix this. Can you give it a test and let me know if it worked? Should leave any instances of \" intact.

from yet-another-bench-script.

I don't know how to test this particular case, I would need a server with an IP address tied to those special ip info strings, which I don't have. But I received a few yabs in the past 10 hours from random IPs, I ran one myself and the generated json is valid.
Thank you for the fix!

from yet-another-bench-script.

Right, makes sense. Well please let me know if this comes up again and we'll re-open this issue!

No problem, thanks for the bug report!

from yet-another-bench-script.