Giter VIP home page Giter VIP logo

Comments (10)

meier-rene avatar meier-rene commented on August 20, 2024 1

I will not fix existing releases, but rather release fixed version with new version number. If you can easily fix that for your dataset right now, then please do it. In addition to fixing this particular problem, I would also like to implement a automatic test which identifies similar problems for existing data and future contributions.

from massbank-data.

meier-rene avatar meier-rene commented on August 20, 2024 1

Asap, but first I would like to release the software stack. I would guess end of the week I might be done with fixing data.

from massbank-data.

meier-rene avatar meier-rene commented on August 20, 2024 1

The issue is fixed with 43e98fb in dev. The issue you reported was the only one of that kind. Could not find any other duplicates.
I want to wait for the answer of an contributor before I make a new data release. Release will be very soon.

from massbank-data.

meier-rene avatar meier-rene commented on August 20, 2024 1

Data is ready to be released, but I cant do it. The merge to main branch requires the successful report from the CI pipeline. Unfortunately the maven repo, from which we pull the SPLASH library is down. Nothing I can do to fix that. I would like to wait a little bit, before I make major changes to build infrastructure...

from massbank-data.

meier-rene avatar meier-rene commented on August 20, 2024 1

Solved with 2012.12.1 release. Thanks for reporting!

from massbank-data.

sneumann avatar sneumann commented on August 20, 2024

Thanks for spotting. That is from an ancient perl script extracting spectral data from ACD SpecManager database. The duplication might be a result of merging FRAGMENTATION_MODE and FRAGMENTATION_METHOD Yours, Steffen

from massbank-data.

jorainer avatar jorainer commented on August 20, 2024

Are you planning to fix that and provide an updated 2022.12 release? just to know if I should make an intermediate fix or wait for the official fix...

from massbank-data.

jorainer avatar jorainer commented on August 20, 2024

Thanks @meier-rene for the update - do you know already when you will release the next version?

from massbank-data.

jorainer avatar jorainer commented on August 20, 2024

Perfect! Thanks! and yes, I also checked all records and these were the only ones with duplicates.

from massbank-data.

jorainer avatar jorainer commented on August 20, 2024

All good - just post here (or even better close the issue) once the data is released so I get notified automatically.

from massbank-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.