Comments (4)
keldonin
commented on May 27, 2024
Hi @LudovicRousseau , thanks for reporting this.
In theory, yes, you are right, generated source files should not be committed to GIT. However there are cases where it is acceptable, see e.g. gnulib doc for detailed info.
The reason why these are left out there is to allow easy build on platforms where you don't necessarily have autotools deployed (or an old version). On such platforms, you can directly execute ./configure. This has been the case on e.g. AIX or Solaris.
I could add a bootstrap.shto the project, if that helps on your side for CI/CD purposes.
I am open to propositions, as long as they allow an easy build process on all platforms.
Regards,
from pkcs11-tools.
LudovicRousseau
commented on May 27, 2024
I understand.
I was not talking about files from Gnulib.
In general your end users should use the pkcs11-tools-1.0.2.tar.gz archive generated by make dist. This archive contains all the needed files (./configure, etc.) with no need to install autotools.
from pkcs11-tools.
keldonin
commented on May 27, 2024
Sorry, for some reason I missed your comment. I will need to rework the project somehow, to remove all the generated source code.
BTW Feel free to propose a PR!
from pkcs11-tools.
keldonin
commented on May 27, 2024
fixed in commit 2ab2172, tag v1.1.0
from pkcs11-tools.
Related Issues (20)
- `p11wrap` is mistakenly adding `CKA_EC_PARAMS` attribute.
- wrapped keys should have `CKA_EXRTACTABLE` set to `false` by default
- README.md Typos HOT 2
- "configure.ac:47: error: possibly undefined macro: AC_MSG_WARN" on CentOS 7.8 HOT 5
- Compilation failed HOT 5
- rpmbuild: fails because of missing pkcs11_ossl.h in the tar.gz and INSTALL.md has a typo HOT 2
- Issue when autoreconf -vfi is run from bootstrap.sh HOT 1
- C_WrapKey using AES key to wrap ED448 and ED25519 fails for CKM_AES_KEY_WRAP_PAD with CKR_KEY_NOT_WRAPPABLE HOT 2
- p11mkcert Make failed HOT 3
- bootstrapping failed. HOT 2
- Some wrong names for hashes and MGF in the manual HOT 4
- (Help, please) no way to build the source code on Ubuntu 20... HOT 7
- issues with eddsa after keygen HOT 9
- p11keygen ignores some of unknown argument HOT 2
- build failure on Linux HOT 9
- ubuntu 22.04 Compilation error HOT 2
- bootstrap error Ubuntu 22.04 HOT 3
- AES support HOT 1
- p11req -X option results in malloc failure HOT 3
- Failing compilation on Ubuntu 22.04 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pkcs11-tools.