Giter VIP home page Giter VIP logo

Comments (13)

billyswong avatar billyswong commented on August 28, 2024 3

Imagine the next time the new URL being longer than the old URL. Ad-hoc patching like what people are doing now won't work.

from libmateweather.

billyswong avatar billyswong commented on August 28, 2024 1

Ad-hoc patching seems not working for some people running older Linux distributions. If they don't get the patch from distribution repository at the end, they probably need to compile the library by themselves.

For where to put the URL information, those 3rd party URLs for example can be put into an extra text-format file in /usr/share/libmateweather, where currently only contains the location data in XML.

from libmateweather.

rob5n avatar rob5n commented on August 28, 2024 1

How is the average user going to know what the new weather service URL is?

What if the latest URL was stored in a file on github, and the app would occasionally pull the file down and store locally. If it can't find the file on github then use the URL in the local file.

from libmateweather.

pepa65 avatar pepa65 commented on August 28, 2024 1

That would be a great solution! It could be locally edited, but it could all happen automatically too..!

from libmateweather.

procule avatar procule commented on August 28, 2024 1

Ad-hoc patching seems not working for some people running older Linux distributions. If they don't get the patch from distribution repository at the end, they probably need to compile the library by themselves.

It was my case and even recompiling the library didn't work. My guess is that it is related to another linked library (libsoup) doing the request. I have sent a PR to resolve the issue: #131

from libmateweather.

bttrx avatar bttrx commented on August 28, 2024 1

I have patched my patch-hack to not include www. in the link, avoiding a 308 redirect which might be causing problems: patchmatelibweather

Your patch is wrong. The search pattern should include www., but the replace pattern not. See https://forums.linuxmint.com/viewtopic.php?p=2399362#p2399362

from libmateweather.

pepa65 avatar pepa65 commented on August 28, 2024

I guess this is the time to do it! Hopefully it will be easier for users to change the URL in case changes happen.

from libmateweather.

raveit65 avatar raveit65 commented on August 28, 2024

New releases for 1.26 and master branch https://github.com/mate-desktop/libmateweather/releases

from libmateweather.

pepa65 avatar pepa65 commented on August 28, 2024

Excellent idea to use a currently already used file location for storing the URL(s) in!

from libmateweather.

lukefromdc avatar lukefromdc commented on August 28, 2024

With libmateweather from current git master I had no trouble showing weather for a nearby airport in the US

from libmateweather.

pepa65 avatar pepa65 commented on August 28, 2024

I have patched my patch-hack to not include www. in the link, avoiding a 308 redirect which might be causing problems:
patchmatelibweather

from libmateweather.

pepa65 avatar pepa65 commented on August 28, 2024

Your patch is wrong. The search pattern should include www., but the replace pattern not.

Absolutely right, thanks, good catch. It seems I patched my patch way too hastily.
Corrected now.

from libmateweather.

L-U-T-i avatar L-U-T-i commented on August 28, 2024

How is the average user going to know what the new weather service URL is?

What if the latest URL was stored in a file on github, and the app would occasionally pull the file down and store locally. If it can't find the file on github then use the URL in the local file.

If the average user can not find a new weather service URL (by a google search for instance, or in this particular case through a server response code / redirect), he / she should:
a) get some professional help
b) wait "things to resolve by themselves" (by a package update, if he/she ia able at least to do that...)
I mean generally, for any computer issues.

Probably there wouldn't be /etc directory and/or dconf settings at all if such users would be a reference.

I think some simple way to change this URL (or any other setting that can change over night) would be a great addition, as one has a much more simple way to resolve even temporary changes. For such an average user, nothing would become more complicated though. Meaning a benefit for those who can use it, and no loss for the others.

Your proposal is just another exactly the same problem. Also a github file URL can change, so there would be a need to simply change that setting too. But how shall an average user know that... ;-)

from libmateweather.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.