[mate-maximus] Undecorate maximized windows doesn't always work about mate-netbook HOT 5 OPEN

Have you solved this issue?

from mate-netbook.

No, not in this version of MATE. I haven't tried 1.26 yet.

from mate-netbook.

I've just tried with MATE 1.26. The issue is still present. The results are:

• Marco (built-in: Xpresent): Works around 50% of the time
• Marco (No compositor), Marco (picom: Xrender), Marco (picom: GLX), Marco (picom: Hybrid): Works around 1 out of 20 times

from mate-netbook.

The problem seems to be with this conditional:
https://github.com/mate-desktop/mate-netbook/blob/v1.26.0/maximus/maximus-app.c#L306-L314

If I remove that then it always undecorates newly opened maximised windows.

But it incorrectly removes decoration for windows that can't be maximised, e.g. mate-tweak.

I'm not sure what to do with this but I get the following values with setvbuf(stdout, NULL, _IONBF, 0); and printf("%d", ...):

actions: 521201
WNCK_WINDOW_ACTION_RESIZE: 2
WNCK_WINDOW_ACTION_MAXIMIZE_HORIZONTALLY: 16
WNCK_WINDOW_ACTION_MAXIMIZE_VERTICALLY: 32
WNCK_WINDOW_ACTION_MAXIMIZE: 16384

When it rarely undecorates a maximised window correctly then I get actions: 522231. That comes from wnck_window_get_actions, which returns window->priv->actions, so I guess either the problem is in update_actions or it's not called every time it should be. These are in libwnck.

If I switch back to the default compositor then I always get 522231 (for windows that are allowed to be maximised).

from mate-netbook.

Adding actions |= WNCK_WINDOW_ACTION_RESIZE; after this line: https://github.com/mate-desktop/mate-netbook/blob/v1.26.0/maximus/maximus-app.c#L307 seems to fix this. It's very likely not the correct way to do it but I don't see it causing any issues so far.

from mate-netbook.