Giter VIP home page Giter VIP logo

Comments (14)

infirit avatar infirit commented on August 28, 2024

I can make the notification read by changing Gtk+'s window from GTK_WINDOW_POPUP to GTK_WINDOW_TOPLEVEL. But I do not understand why windows of type GTK_WINDOW_POPUP are ignored by orca 😕.

See below for quick hack to change the window type for the standard theme.

diff --git a/src/themes/standard/theme.c b/src/themes/standard/theme.c
index 09aa628..cc0bd75 100644
--- a/src/themes/standard/theme.c
+++ b/src/themes/standard/theme.c
@@ -640,7 +640,8 @@ GtkWindow* create_notification(UrlClickedCb url_clicked)
    windata->urgency = URGENCY_NORMAL;
    windata->url_clicked = url_clicked;

-   win = gtk_window_new(GTK_WINDOW_POPUP);
+   win = gtk_window_new(GTK_WINDOW_TOPLEVEL);
+   gtk_window_set_decorated (win, FALSE);
    windata->win = win;

    windata->composited = FALSE;

from mate-notification-daemon.

monsta avatar monsta commented on August 28, 2024

@coffeeking: can you please check if it still happens in 1.12?

from mate-notification-daemon.

coffeeking avatar coffeeking commented on August 28, 2024

Confirmed. This does indeed still happen in 1.12. In addition, replacing mate's notification-daemon with notify-osd no longer works

from mate-notification-daemon.

monsta avatar monsta commented on August 28, 2024

Ok, what can be done about it then - in regards to what's written above about GTK_WINDOW_POPUP?

from mate-notification-daemon.

coffeeking avatar coffeeking commented on August 28, 2024

I'm not completely sure, but if changing the window style works, I'd suggest doing so for all the provided notification themes, standard, nadoka, slider, coko, etc. I'll also inquire on the orca list to see if joanmeri diggs can find out why the notifications aren't working like they should

from mate-notification-daemon.

lukefromdc avatar lukefromdc commented on August 28, 2024

Seems to me a direct audio notification option (possibly by a special theme engine hooked into Orca's audio system) would be the best possible approach to this. No idea how to code it though, and when I tried to test Orca on my system (a hacked Debian Unstable full of locally compiled stuff) some kind of audio bugs made it impossible to get any audio from it.

from mate-notification-daemon.

raveit65 avatar raveit65 commented on August 28, 2024

@coffeeking
Can you test 2111df3
which is in 1.15.1 release.
I made header and body translatable, hopefully this was the issue

from mate-notification-daemon.

coffeeking avatar coffeeking commented on August 28, 2024

hi
I'm so sorry, I never did close this one, did I. I fixed this ages ago.
All it took was adding mate's notification daemon to the default script,
essentially telling orca that anything coming in from that program was a
notification and to read it. For some reason orca wasn't noticing that
before. This means that all mate versions have accessible notifications,
at least everything since 1.8 does. However, I will test this commit to
see what it does.
Thanks
Kendell Clark

raveit65 wrote:

@coffeeking https://github.com/coffeeking
Can you test 2111df3
2111df3
which is in 1.15.1 release.
I made header and body translatable, hopefully this was the issue


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#30 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABzGmJPEFnqih90ACTgVWYhNyiQ39rYpks5qQoMvgaJpZM4Bo0eh.

from mate-notification-daemon.

monsta avatar monsta commented on August 28, 2024

Oh. So we don't need to try to change window style? 😄

from mate-notification-daemon.

coffeeking avatar coffeeking commented on August 28, 2024

hi
It's not necessary to allow orca to read it, but this commit does make
orca read the notifications better. Before this orca would occasionally
miss a notification or two, but with this change it doesn't miss them,
so it's good that you made it.
Thanks
Kendell Clark

monsta wrote:

Oh. So we don't need to try to change window style? 😄


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#30 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABzGmEWRLmPtf_6_LoG8-zNHrNQUkG-Yks5qQroRgaJpZM4Bo0eh.

from mate-notification-daemon.

raveit65 avatar raveit65 commented on August 28, 2024

FIne,
i will backport this commit to 1.14 branch

from mate-notification-daemon.

raveit65 avatar raveit65 commented on August 28, 2024

Oh. So we don't need to try to change window style? 😄

I think the fix for notification window hint did also improve the situation.

from mate-notification-daemon.

monsta avatar monsta commented on August 28, 2024

Ok, so can we close this now, or is there something else to do here?

from mate-notification-daemon.

raveit65 avatar raveit65 commented on August 28, 2024

@coffeeking
I've releases 1.14.1 with that improvement.
I hope you agree with closing this issue, if not mention it here and we will reopen it.

from mate-notification-daemon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.