Giter VIP home page Giter VIP logo

Comments (4)

raveit65 avatar raveit65 commented on July 24, 2024

Yes, for this reason i don't use libappindicator for fedora builds. For me libindicator status icon should be use the same behaviour than normal build.

from mate-polkit.

lukefromdc avatar lukefromdc commented on July 24, 2024

I will try to debug this myself, if I am not successful I will also disable it in my builds. At the moment using it to work on a PR for the panel,
mate-desktop/mate-panel#583
at it showed that the new status-nofifier work does not include the panel menu theme support work I did two years ago, and thus menus come up mismatched if the theme sets a different panel menu theme (as mine does)

from mate-polkit.

lukefromdc avatar lukefromdc commented on July 24, 2024

lukefromdc@4303d60
is a rough workaround for this. It quits the whole application and lets it respawn. This occurs only when build with appindicator support, the tray icon codepath is unchanged. NO PR as of now, but I am using it.

Mate-polkit from master works fine in gnome-panel, but mate-desktop/mate-panel@36c5430#diff-6ef0fc6b7e60a4b669e65fa5a7c84435 causes "passive" items to always show, and thus prevents the icon from being removed. I tested reverting this, and was even able to test for the icon name to limit it to mate-polkit, only to find that either permitted the icon to show and be removed once, then it would not show again. Would show again fine in gnome-panel, something didn't update correctly in mate-panel.

Thus, three possible fixes exist:
1: Special case this in the tray sn-notifier/tray applet and fix that failure to update. Best possible way, but I have no idea in the world where that failure to update on

2: Kill the whole app and let is respawn. Apparently the icon will persist as "passive" even after the app_indicator structure is unref'ed and nulled out, so long as the app is running.

3: Create an "null icon" of zero (or maybe 1x1 transparent?) pixel width and height so it does not take up space or show up but with a filename, and reset the icon to that on dropping privileges, then set it back if they are raised again. I tested setting the icon to NULL, but that hits an assertation, and setting the icon to an invalid name brpught up the missing icon icon. Downside here is some users might notice the tray being 1px wider after they have raised privileges oncel

Is anyone using mate-polkit from the command line or in one-shot start sessions? If so, I will rework this to use the empty icon that takes no space instead of stopping and restarting.

from mate-polkit.

lukefromdc avatar lukefromdc commented on July 24, 2024

Finally found a way to fix this right, but this required changes in both mate-panel
mate-desktop/mate-panel#669
to hide this icon when passive and no others
and in mate-polkit
#38
to keep the same app_indicator alive so the icon could be shown more than once.

from mate-polkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.