right/left mouse clicks are reversed at brightness applet slider about mate-power-manager HOT 15 CLOSED

I tried to compile this with gtk 2.24.22:

brightness-applet.c: In function 'gpm_applet_create_popup':
brightness-applet.c:660:42: error: lvalue required as left operand of assignment
GTK_WIDGET_UNSET_FLAGS (applet->popup, GTK_TOPLEVEL);

What is wrong?

from mate-power-manager.

did you build from git?

from mate-power-manager.

No. I tried to compile the released 1.8.0 package.

from mate-power-manager.

Try build with --disable-strict , normaly this is only needed for git builds.
For fedora rawhide the1.8.0 release builds fine, see
http://koji.fedoraproject.org/koji/buildinfo?buildID=502694

from mate-power-manager.

I compiled the 1.6 / 1.7 releases with --enable-strict option.
Now I removed this option, and I built it succesfully the 1.8.0 release.
Thank you for the suggestion.

from mate-power-manager.

@NiceandGently could we close this issue now?

from mate-power-manager.

I noticed the same issue is back with GTK3.

from mate-power-manager.

re-opend because it is broken with gtk3

from mate-power-manager.

I can compile it with this patch:
https://gist.github.com/rezso/9db8c4aa202790607f4b

from mate-power-manager.

@rezso
this is for gtk2 build ?

from mate-power-manager.

@raveit65
No. This is for gtk2 and gtk3 build.
gtk_widget_set_can_focus is useable since gtk 2.18, mate-power-manager requires gtk2 2.24 or gtk3.

from mate-power-manager.

thx for clarifications, i did ask because i prepared a more extended patch yet :)
https://dl.dropboxusercontent.com/u/49862637/Mate-desktop/Bugs/mate-power-manager_fix-brightness-applet-new.patch
.......more than 1 way to rome......

from mate-power-manager.

Your patch made for mouse clicks, mine is simple build fix for #62 (comment).

from mate-power-manager.

I know what my patch was made for, but you did't say for what your patch is good for.....
Header is not about using --strict or not.
Anyways, i will include your suggestion

from mate-power-manager.

hmm, with your patch the brightness slider isn't selectable again with gtk2 build.

from mate-power-manager.