Giter VIP home page Giter VIP logo

Comments (8)

matepek avatar matepek commented on May 27, 2024

I'm using the findFiles endpoint to query files. According to the documentation if the second parameter is null, it should not use the default exclusion pattern. I interpret this that it should work, because I am passing null as second parameter.

I might misinterpret the documentation or there is vscode bug.

from vscode-catch2-test-adapter.

deitry avatar deitry commented on May 27, 2024

Thanks for the quick reply!
I found related issue: microsoft/vscode#48674
It seems that files.exclude IS default exclusion path.

I guess the easiest way to have both features would be to add exclude option to this extension which would be passed instead of null.

from vscode-catch2-test-adapter.

matepek avatar matepek commented on May 27, 2024

Nore that “undefined” and “null” are different values in JavaScript.
Since you are talking about “undefined”, you might missed that. If not then I am missing something, please explain what do you mean.

from vscode-catch2-test-adapter.

deitry avatar deitry commented on May 27, 2024

I'm bad in JS so I talk only about files detection dependency on files.exclude option. undefined is discussed in the VS Code issue which I suppose to be related.

I guess this issue could be called a feature request to have independent exclude configuration entry.

from vscode-catch2-test-adapter.

matepek avatar matepek commented on May 27, 2024

Disagree:

When undefined only default excludes will apply, when null no excludes will apply.

(See doc)
According to the documentation null would work, and I using it. So if it is not working it is a vscode bug related to null, not undefined.

from vscode-catch2-test-adapter.

deitry avatar deitry commented on May 27, 2024

Oh, I get it now.

from vscode-catch2-test-adapter.

deitry avatar deitry commented on May 27, 2024

microsoft/vscode@c467419

When null, no search excludes will apply, but files.exclude will still apply.

This is current behaviour, but I hope there would be discussion on changing it:
microsoft/vscode#77813

from vscode-catch2-test-adapter.

matepek avatar matepek commented on May 27, 2024

For default exclude there is undefined value.

They reopened your issue 👍

I will close this if you don't mind and hope that vscode fixes its API.

from vscode-catch2-test-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.