Giter VIP home page Giter VIP logo

Comments (5)

chrisbanes avatar chrisbanes commented on May 18, 2024

First of all, this isn't a library issue. You're not invoking any MDC Adapter code (or even Compose code for that matter) so there's no way it can alter the theme. This library also doesn't modify the theme in any way.

This looks to me like a Gradle transitive dependency issue. This library depends on MDC 1.1.0, to not force consumers to upgrade if they don't want/need to. I'd try forcing the MDC version you want using by overriding the transitive dependency version:

implementation 'com.google.android.material:material:1.2.1!!'

This should happen automatically, since:

Gradle resolves any dependency version conflicts by selecting the latest version found in the dependency graph

But maybe being a feature module is how messing with it some how.

from material-components-android-compose-theme-adapter.

chrisbanes avatar chrisbanes commented on May 18, 2024

Looked more into this. It's not a transitive dependency issue, the MDC dependency gets correctly upgraded to: com.google.android.material:material:1.1.0 -> 1.2.1 (*).

This looks to me like a feature module issue. If I add implementation 'com.google.android.material:compose-theme-adapter:1.0.0-alpha02' to the app module (as well as the feature module), it all works correctly. I'm guessing that the resource IDs are somehow not correctly resolved when the dependency is only the feature module. Not much we can do in the library though.

from material-components-android-compose-theme-adapter.

chrisbanes avatar chrisbanes commented on May 18, 2024

Adding @keyboardsurfer @wojtek-kalicinski

from material-components-android-compose-theme-adapter.

keyboardsurfer avatar keyboardsurfer commented on May 18, 2024

I can reproduce the issue. For now, replacing ?textAppearanceHeadline3 with @style/TextAppearance.MaterialComponents.Headline3 is a feasible workaround.
We'll have to look into this more in depth to get it fully resolved though.

from material-components-android-compose-theme-adapter.

fbarthelery avatar fbarthelery commented on May 18, 2024

I agree this is not a library issue but I had no clue where to start.

I'm happy to fill an issue in the correct component so this can be followed up properly.

from material-components-android-compose-theme-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.