Comments (19)
@oze4 Hi, I'm the author of the MUI5 conversion pull request on original repository. If this PR is any use here I could try to port it over here. Let me know if I could help you here.
from core.
I think focusing on MUI compatibility in the next
repo makes more sense. As you say, there are nice features, but it is still in alpha. So I don't see a need for this to take priority right now, or in this repo.
Thoughts?
from core.
Any word on this? Would love to see the onPageChange
vs onChangePage
changes get pulled into this.
from core.
I just started working on a migration to v5. I started with the third level imports to fix the tests and will move to the pagination issue next, which looks like is the only error for v5.30 as far as I can see.
from core.
@VladLegkowski looks like we will have an alpha version of the library that will support mui 5.
In the meantime you can go as far as version 5.0.11 of mui, because there are no breaking changes until then
from core.
Nothing either here or in original repo. Meanwhile I bumped my PR to latest alpha, there were no immediately noticable breaking changes.
from core.
I updated upstream pull request to v5.0.0-alpha.34
level
from core.
Thank you for this. Is that the best way to handle this? Just use another branch? We currently have a next
repo which we are moving to TS.
from core.
We might also start to be compatible with only MUI 5, if maintaining two versions is too much.
It's true that it is still marked as alpha, but per my use I see it as pretty stable. And there a lot of nice things with moving to version 5 😄
https://medium.com/material-ui/2020-in-review-and-beyond-55d2cab0975c
from core.
Agreed!
from core.
Hi, i noticed that react 17 is already used, but in MUI 4 only react 16 is supported officially. Was this done on purpose. Could any problems arise ?
npm WARN @material-table/[email protected] requires a peer of react@^17.0.1 but none is installed. You must install peer dependencies yourself.
from core.
@masbaehr on my projects I'm not running into any issue. I'm also using MUI 5.0.0-alpha.11 and looks like this library is compatible until that one version.
from core.
Hi guys,
I am seeing these issues with MUI5 and material-table-core/core
.
Warning: Failed prop type: The prop onPageChange is marked as required in ForwardRef(TablePagination), but its value is undefined.
Warning: Unknown event handler property onChangePage. It will be ignored.
Warning: Unknown event handler property onChangeRowsPerPage. It will be ignored.
Material-UI: The fade color utility was renamed to alpha to better describe its functionality.
Package.json
"@material-table/core": "^2.3.24",
"@material-ui/core": "^5.0.0-alpha.23",
from core.
Ah, I already did this migration in my codebase - https://next.material-ui.com/guides/migration-v4/.
I will need to roll back a lot of stuff to make it compatible. @vmihalachi, I know I don't deserve even to ask this question, because I can only imagine how hard it is to maintain OS package like this, but you have any idea when you will have the alpha
version?
Thank you.
from core.
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^17.0.1" from @material-table/[email protected]
Happened again with an older project i wanted to upgrade to table/core
I think react 16 should still be supported until MUI v5 is final, as react 17 is not supported by MUI v4
from core.
@villuv is there any way to download an alpha version with these changes?
from core.
@vmihalachi Just fork my version of it from https://github.com/villuv/material-table/tree/feature/mui5 and check out feature/mui5
branch. I haven't published a built package as I haven't thorougly tested it. It builds fine with yarn install; yarn build
and you can use it locally with yalc, for example. Let me know if you find anything wonky.
from core.
Feel free to send of a PR of your fork with MUI5 compatibility and we will get it merged. Thanks!
from core.
The next branch supports v5. Closing this.
from core.
Related Issues (20)
- onRowUpdateCancelled doesn't return any rowData information HOT 5
- Deselect all programatically HOT 2
- Update dependencies HOT 5
- Columns aren't sortable if they use `render` instead of `field` HOT 2
- Request for Feature Addition: Custom Styling for Actions Cell in Row Editing HOT 2
- Child row of a child row does not show "Are you sure you want to delete this row?" HOT 9
- Warning: MTableHeader: Support for defaultProps will be removed from function components in a future major release HOT 5
- Seems like MaterialTable is not compatible with ES Modules HOT 3
- date-fns V3 and material-table 6.4.1 throws parseISO error when a column has a type of "date"/"datetime" HOT 4
- Any possible way to toggle child row programmatically easily ? HOT 2
- Column sorting for fields that start with "current" breaks after data update HOT 1
- Column filtering is broken after update HOT 1
- Title: WCAG 4.1.2: Ensures every form element has a label (.PrivateSwitchBase-input-317[value=""][data-indeterminate="false"]) HOT 3
- column filtering is nolonger working in version "@material-table/core": "^6.4.3", HOT 3
- what's the purpose of imported { Column } from @material-table/core ?
- Build error from new version of dependecy Zustand HOT 1
- Warning `columns` is marked as required in `MTableAction`, but its value is `undefined` HOT 1
- Unexpected behavior with TotalCount and page properties HOT 1
- Save/Restore sorting with remote data
- Table is not refreshed with remote data HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.