Giter VIP home page Giter VIP logo

Comments (8)

Keboo avatar Keboo commented on June 19, 2024 1

@nicolaihenriksen ah thank you, yes i misread the original issue. And thank you for the PR

from materialdesigninxamltoolkit.

mr-luiks avatar mr-luiks commented on June 19, 2024

using DrawerHost fixes floating hint background issue tough.

but i also noticed that foreground is different from release version and pre-release version.
on 5.0.0 floating hint foreground colour is muted version of a elements foreground colour. on pre-release it is a same colour. is this a new look or is a bug?

Untitled-1

from materialdesigninxamltoolkit.

nicolaihenriksen avatar nicolaihenriksen commented on June 19, 2024

... but i also noticed that foreground is different from release version and pre-release version. on 5.0.0 floating hint foreground colour is muted version of a elements foreground colour. on pre-release it is a same colour. is this a new look or is a bug?

This was probably something that happened while aligning the "field" styles while incorporating the new SmartHint. Judging from the MD2 "spec" I would say it is a bug though. @Keboo thoughts?

from materialdesigninxamltoolkit.

nicolaihenriksen avatar nicolaihenriksen commented on June 19, 2024

@mr-luiks Have you tried setting the Style on the window explicitly: Style="{StaticResource MaterialDesignWindow}"

from materialdesigninxamltoolkit.

mr-luiks avatar mr-luiks commented on June 19, 2024

@mr-luiks Have you tried setting the Style on the window explicitly: Style="{StaticResource MaterialDesignWindow}"

yes, this is how i apply window style for my program and result is same as previous examples.

from materialdesigninxamltoolkit.

Keboo avatar Keboo commented on June 19, 2024

... but i also noticed that foreground is different from release version and pre-release version. on 5.0.0 floating hint foreground colour is muted version of a elements foreground colour. on pre-release it is a same colour. is this a new look or is a bug?

This was probably something that happened while aligning the "field" styles while incorporating the new SmartHint. Judging from the MD2 "spec" I would say it is a bug though. @Keboo thoughts?

Yea I am thinking it looks like a bug. From the spec I would expect the floating color to follow the primary color.

from materialdesigninxamltoolkit.

nicolaihenriksen avatar nicolaihenriksen commented on June 19, 2024

@Keboo I think what the OP is referring to here is not actually the floating color, but rather that the resting color should be a dimmed version of the TextElement.Foreground color.

The floating color I believe is correct, it follows the primary color when the control has focus, otherwise it falls back to TextElement.Foreground.

image
image

Also, it is obvious that there is a difference when looking at the SmartHint demo page. It seems the outlined style is correctly dimming the hint, whereas the other styles are not.

image

This is the same for all the input controls; I'll have a look at aligning that across the styles.

from materialdesigninxamltoolkit.

nicolaihenriksen avatar nicolaihenriksen commented on June 19, 2024

@mr-luiks @Keboo after digging a little, I can see that this is the PR that introduced the issue: #3544

Reverting that change fixes the chrome issue, but of course re-introduces the clipping issue which the PR was fixing.

I'll spend some time looking into a solution...

from materialdesigninxamltoolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.