Bug: The `.as_dict()` method on `CrystalSystem` is not Monty compatible about emmet HOT 6 OPEN

So I think the custom as_dict for this takes precedence over the new general for the Enums

So something like this should work.

from monty.serialization import dumpfn
from enum import Enum
class Test(Enum):
    a = "a"
    b = "b"
t = Test.a
dumpfn(t, "test.json")

So I think if we just remove the custom as_dict and from_dict for that class then things should work. But we will have a see about the consequences.

from emmet.

Looks like I ran into something similar, resolved on monty's side:
materialsvirtuallab/monty#602

from emmet.

Oh that was smart! Thanks!! I'll check if is resolved with the monty update.

from emmet.

Looks like your PR didn't fix this one btw, @jmmshn. I'll have to dig into it later.

from emmet.

Thanks for the pointer, @jmmshn! Removing the .as_dict() method in emmet.core.utils.ValueEnum results in an AttributeError:

AttributeError: 'CrystalSystem' object has no attribute 'as_dict'

I'll dig into this later in the week. I think I know where to look now. 👍

from emmet.

@munrojm can you please re-open this? It won't let me do so. It needs to be reopened due to #974.

from emmet.