[QUESTION] Topic required on KafkaProducerMessage duplicated in CanProduceMessages about laravel-kafka HOT 3 CLOSED

Hello @thetomcake, i just released v1.3.0 of this package. Here's the changelog: https://github.com/mateusjunges/laravel-kafka/blob/v1.3.0/CHANGELOG.md

from laravel-kafka.

Hello @thetomcake, first of all, thanks for your feedback on this library.
The topic name on the message is used only if you are using the Kafka::fake() method, to assert the a message was published specifically on the given topic. I agree with you and already fixed it to be passed to the message automatically, so you don't need to repeat the argument just to use it on tests.
About the documentation, i checked it and in fact is is incorrect. Will be fixed as soon as i release the next version (later today or maximun tomorrow morning). Also, the broker parameter on publishOn will be optional, since we can use config files for that.

from laravel-kafka.

Hello @thetomcake, first of all, thanks for your feedback on this library. The topic name on the message is used only if you are using the Kafka::fake() method, to assert the a message was published specifically on the given topic. I agree with you and already fixed it to be passed to the message automatically, so you don't need to repeat the argument just to use it on tests. About the documentation, i checked it and in fact is is incorrect. Will be fixed as soon as i release the next version (later today or maximun tomorrow morning). Also, the broker parameter on publishOn will be optional, since we can use config files for that.

No problem @mateusjunges, we're fairly new to Kafka over here, so wanted to make sure I didn't get the complete wrong end of the stick. Glad we could help, we will be using the library in some fairly large apps in the next few weeks so might throw some more PRs your way.

You've answered my issue above, thanks a lot.

from laravel-kafka.