Producer: performance issue due to flush call about laravel-kafka HOT 5 CLOSED

I wrote the first version for this. I don't want to completely remove the flush call, so I added a call to laravel lottery class to call it for 0.5% of messages only. You can keep the old behavior by passing a shouldFlush boolean to the send method

Please take a look at this PR and let me know what you think #252

from laravel-kafka.

Thanks! I'll release this in v2 as it's a breaking change and I can't change contracts without breaking existing applications

from laravel-kafka.

@mateusjunges
Thanks for assistance and so quick code improvement. PR looks fine, new param definitely the easiest way imho.

after merging will reintergate package to my project :) thanks one more time!

from laravel-kafka.

Closing this as #252 is merged. Finishing some last improvements before releasing v2

from laravel-kafka.

Hi, thanks for the package, it's great! Today I spent some time to understand, that by default shouldFlush is set to false.
Example of producing single message from the docs does not work because of that! Maybe for the case of single message, it's worth adding an example with shouldFlush set to true?

from laravel-kafka.