Giter VIP home page Giter VIP logo

Comments (5)

krizpoon avatar krizpoon commented on June 4, 2024 2

This gave me a surprise too. I think the library should handle the undefined and null cases otherwise we have to write code like he.encode(string || '') all over the place. Or we'll need a wrapper function like
const htmlEncode = (string, options) => typeof string === 'string' ? he.encode(string, options) : '';

from he.

mathiasbynens avatar mathiasbynens commented on June 4, 2024

Do you have a reproducible test case?

from he.

bauer-git avatar bauer-git commented on June 4, 2024

I saw 10 seconds after I wrote this exactly where you initialize 'regexEscape'.

All I can tell you is I'm using this in Joomla - with the Fabrik extension.
If no one else has ever reported this problem, then I assume it's got to be either Joomla, Fabrik, or my browser (latest version of Chrome) that causes/throws the error.

Maybe there is something in either that doesn't allow variables such as what is created when you initialize regexEscape - and all the others done similar fashion? (What var type is that anyhow - is it considered a string?)

Anyhow, I couldn't use your code. Thank you.

from he.

mathiasbynens avatar mathiasbynens commented on June 4, 2024

Again, do you have a test case that reproduces the problem? Otherwise, there’s nothing I can do.

from he.

nico2che avatar nico2che commented on June 4, 2024

This can happen with he.encode(undefined) or he.decode(undefined)

IMHO, if the choice was to not handle undefined or null values, an appropriate error could be throw to prevent this usage instead of an Uncaught TypeError

from he.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.