Comments (5)
This gave me a surprise too. I think the library should handle the undefined and null cases otherwise we have to write code like he.encode(string || '') all over the place. Or we'll need a wrapper function like
const htmlEncode = (string, options) => typeof string === 'string' ? he.encode(string, options) : '';
from he.
Do you have a reproducible test case?
from he.
I saw 10 seconds after I wrote this exactly where you initialize 'regexEscape'.
All I can tell you is I'm using this in Joomla - with the Fabrik extension.
If no one else has ever reported this problem, then I assume it's got to be either Joomla, Fabrik, or my browser (latest version of Chrome) that causes/throws the error.
Maybe there is something in either that doesn't allow variables such as what is created when you initialize regexEscape - and all the others done similar fashion? (What var type is that anyhow - is it considered a string?)
Anyhow, I couldn't use your code. Thank you.
from he.
Again, do you have a test case that reproduces the problem? Otherwise, there’s nothing I can do.
from he.
This can happen with he.encode(undefined)
or he.decode(undefined)
IMHO, if the choice was to not handle undefined
or null
values, an appropriate error could be throw to prevent this usage instead of an Uncaught TypeError
from he.
Related Issues (20)
- Minified version? HOT 10
- Error when minimizing with Google closure-compiler HOT 1
- Non-English support? HOT 1
- Unescape from HTML and escape to JSON HOT 19
- useNamedReferences doesn't work for all characters
- ASCII character 128 not being encoded by he HOT 1
- Let's set up a modern Rollup-based build system HOT 4
- Section 12.2.4.69 of the HTML spec, referenced in README.md, does not exist HOT 1
- Allow to ignore specific elements in the string, like code HOT 3
- Chrome: Uncaught SyntaxError: Unexpected token '<' in he.js:32 HOT 2
- Cannot set property 'he' of undefined
- Memory leak
- Feature request: Add optional support for ISO-8859-1 characters
- What is the correct source for the lib?
- npm audit: 26 vulnerabilities HOT 3
- Git.io deprecation notice
- A new feature suggestion: add an escape option to decode function HOT 1
- As is, code produces an JS error HOT 1
- Not sure why it's not decoding a particular paragraph
- Certain named entities don't decode (& and <) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from he.