Comments (3)
This doesn’t fully fix the issue. Doing so is hard, since JS doesn’t support lookbehind.
var set = regenerate().addRange(0xD800, 0xDBFF).addRange(0xDC00, 0xDFFF);
var regex = RegExp('^a(?:' + set.toString() + ')b$');
// currently, this results in `/^a(?:[\uD800-\uDBFF](?![\uDC00-\uDFFF])|(?:[^\uD800-\uDBFF]|^)[\uDC00-\uDFFF])b$/`
console.log(regex.test('a\uD834b')); // expected: true; actual: true
console.log(regex.test('a\uDC00b')); // expected: true; actual: false
from regenerate.
Given the above code:
var set = regenerate().addRange(0xD800, 0xDBFF).addRange(0xDC00, 0xDFFF);
var regex = RegExp('^a(?:' + set.toString() + ')b$');
// currently, this results in `/^a(?:[\uD800-\uDBFF](?![\uDC00-\uDFFF])|(?:[^\uD800-\uDBFF]|^)[\uDC00-\uDFFF])b$/`
Consider these three tests:
console.log(regex.test('a\uD834b')); // expected: true
console.log(regex.test('a\uDC00b')); // expected: true
console.log(regex.test('a\uD834\uDF06b')); // expected: false
There are two options:
a. Either we pass test 1 and 3 but fail test 2 (i.e. lone low surrogates aren’t matched accurately). (As in the current implementation in v1.2.1.)
b. We pass test 1 and 2 but fail test 3 (i.e., surrogate halves in pairs are matched as if they are lone surrogates).
Which is the lesser evil — a or b?
from regenerate.
As Marja said:
Paired surrogates are the normal case, so I think cases involving only them should have priority.
Let’s go with a
, i.e. the current implementation.
from regenerate.
Related Issues (20)
- Optimization / “bug” with ranges
- `regexNull`: `\08` / `\09`
- Add `regenerate.prototype.remove(fn)`
- Optimize `regenerate.prototype.removeRange`
- Constants for the ranges “BMP code point”, “lead surrogate”, “tail surrogate” HOT 2
- Improve performance / decrease memory usage HOT 3
- Avoid `Array#splice` where possible
- Avoid overhead of calling `dataFromCodePoints()` etc. internally HOT 1
- JavaScript identifier generation script broken since rewrite HOT 3
- Script to convert any Regenerate set to code that generates it
- Bug in `.remove(set)`? HOT 1
- Write a fuzzer to try and find more bugs
- Reduce file size to use it as a RegExp polyfill HOT 1
- Unexpected matches in the resulting RegExp HOT 3
- Add option to output ES6 `u`-compatible patterns
- isArray is not using the native isArray method, causing incompatibilities with prototype.js
- Invert regular expression? HOT 1
- Non-minimal regex when adding a second range lower than the first HOT 1
- Incorrect optimization in surrogateMappings HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from regenerate.