mathigon / hilbert.js Goto Github PK

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• Update dependency tslib to v2.6.2
• Update Test and Build (@typescript-eslint/eslint-plugin, @typescript-eslint/parser, esbuild, eslint, eslint-plugin-import)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

The unary minus operator can't be used after other operators!
Each of these examples throws a SyntaxError during the call to collapse:

Expression.parse("1 * -1").collapse(); // SyntaxError: This expression is invalid.
Expression.parse("1 + -1").collapse(); // SyntaxError: A “+” cannot be followed by a “−”.
Expression.parse("x = -1").collapse(); // SyntaxError: A “=” cannot be followed by a “−”.

The first example being different might be because of special behaviour for implicit multiplication?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• Update Dev Dependencies (esbuild, eslint, tape)
• Update actions/setup-node action to v4
• Update github/codeql-action action to v3
• Update typescript-eslint monorepo to v7 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)

Detected dependencies

Hi, I'm trying to chase down what I regard as a bug - please forgive me if this isn't the right repository.

On the Mathigon circles course, the surface area of a cylinder rejects the solution 2πr(r+h). hilbert.js interprets this as a function:

> hilbert.Expression.parse("2πr(r+h)")
ExprTerm {
  items: [ ExprNumber { n: 2 }, ExprFunction { fn: 'πr', args: [Array] } ]
}

which I think is totally reasonable without any context. What I'd suggest is that once you are aware of the context, if fn isn't a valid function, you fall back to trying to parse it as identifiers times the ( "function". I think the right place to do that is here

https://github.com/mathigon/boost.js/blob/aa980832146a48978f57e047258911a096122915/src/eval.ts#L438

but I'm not sure :)

Suggested failing test:

  test.equal(compile('r(a)')({r: 2, a: 2}), 4); // Fails - returns undefined

One thing I haven't been able to track down so far is how 2rh gets turned into 2*r*h - compile gives me

> compile('2rh')
/home/olie/projects/boost.js/src/eval.ts:72
        throw new Error(`${message} at character ${index} of "${expr}"`);
        ^

Uncaught Error: Variable names cannot start with a number (2r) at character 1 of "2rh"

but this does currently work in Mathigon. Wherever that happens might be the place to handle function composition if you felt like a challenge (probably: check if whole word is a function, if not, from right to left, compose functions if each character is a function; if it isn't, switch to parsing as identifiers from then).

PS: Mathigon is very cool :)

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.