Giter VIP home page Giter VIP logo

Comments (1)

matowens avatar matowens commented on August 28, 2024

Looking through that thread, it appears that there is a bug in protractor that's preventing it from testing correctly. I don't think reworking ngNotify and it's existing tests to appease a bug in another testing framework is a good idea or good use of dev time.

ngNotify uses angular mock in a couple tests that check to see if the correct message is displaying. Those tests run by using the 'grunt test' command. I'd recommend expanding on those existing test cases, or even just using those tests directly, instead of trying to code to fit within the limits of protractor.

There's some info on angular mock here https://docs.angularjs.org/api/ngMock, with support for both $timeout and $interval.

from ng-notify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.