Reject single faulty event instead of the whole room state about gomatrixserverlib HOT 4 CLOSED

Is this actually the intended behaviour? Does the spec say that we should drop and continue joining?

from gomatrixserverlib.

I don't think the spec is clear on it.

This ties into the bigger question of "what should we do if we find an event whose signature we can't verify (possibly because we can't find the signing key)". IMHO failing the join would make joins rather brittle, but it's not obvious.

Relatedly, we broke this in synapse recently (matrix-org/synapse#6978), and it turned out that nobody could join a whole bunch of rooms until we fixed it.

from gomatrixserverlib.

I guess from an attack vector perspective it makes sense not to block the join, else malicious actors could withold their signing key for example and cause chaos.

In scenarios where the failing to get the key is transient, and the events are real and should be included.... I dunno what we should do there.

from gomatrixserverlib.

We reject individual faulty events now.

from gomatrixserverlib.