useBulk uses the wrong value for refresh about dynamodb-stream-elasticsearch HOT 4 CLOSED

That line you linked to pushed the correct value to the toUpsert array, sure. Which is used with toUpsert[0].refresh - so yeah that looks fine. But, like I've tried to explain a few times now it looks like it uses the wrong key when passed along to es.bulk:

from dynamodb-stream-elasticsearch.

Hi @ChristerGustavsson,

You can notice that few lines above there is:
toUpsert.push({ index, id, body, refresh })
so the flag is set correctly. If you run tests you will find that:

  elasticsearch Starting a new request {
  method: 'POST',
  path: '/_bulk',
  bulkBody: [ { delete: [Object] } ],
  querystring: 'refresh=false',
  body: '{"delete":{"_index":"test","_id":"russ-wintheiser-c240e6ac-3"}}\n',
  headers: {
    'user-agent': 'elasticsearch-js/7.7.1 (darwin 20.2.0-x64; Node.js v14.15.3)',
    'content-type': 'application/x-ndjson',
    'content-length': '64'
  },
  timeout: 30000
} +154ms

Closing.

from dynamodb-stream-elasticsearch.

That test you did seems to be for delete not upserts, and that looks fine and uses the correct key for es.bulk:

But if you look for upsert es.bulk:

from dynamodb-stream-elasticsearch.

Right, I put a wrong test example. Looking a code bulk uses correct value for refresh:
https://github.com/matrus2/dynamodb-stream-elasticsearch/blob/master/src/index.js#L62

from dynamodb-stream-elasticsearch.