Giter VIP home page Giter VIP logo

Comments (7)

keithamus avatar keithamus commented on May 17, 2024

#178:

  • + Emoji
  • + Notifications
  • + Configurable
  • + Better metadata
  • - Writes multiple files
  • - Needs shellcheck changes

#177:

  • + Code more readable
  • + Shellchecked (now)
  • + Original

from xbar-plugins.

manojlds avatar manojlds commented on May 17, 2024

#178 👍

from xbar-plugins.

gorangajic avatar gorangajic commented on May 17, 2024

I have searched plugins for pomodoro but forget to look up in pull requests 😄 what are the changes that 2 people are working on the same thing in the same time ?

Imo we should merge both plugins because functionality is a bit different #178 have two timers(work and break) that switch automatically, and #177 have just one timer that need to be restarted manually

also #178 play a sound when timer reach 00:00

Writes multiple files

I can move that in one file but wanted to keep things more simpler

btw #177 have bug, config files should be moved from plugin directory because bitbar treat that file like a new plugin so there is new warning icon ⚠️

no hard feelings, whatever you guys decide 😄

from xbar-plugins.

matryer avatar matryer commented on May 17, 2024

What's funny is - a friend of mine has started work on a Pomodoro plugin too - I've sent him a link to this. :)

from xbar-plugins.

matryer avatar matryer commented on May 17, 2024

Shall we spellcheck it and go with #178 then?

from xbar-plugins.

keithamus avatar keithamus commented on May 17, 2024

Sounds like an idea.

from xbar-plugins.

sagarjauhari avatar sagarjauhari commented on May 17, 2024

Ahh, found this just when I was about to open a PR for a Pomodoro plugin I wrote too! https://github.com/sagarjauhari/pomodoro.rb/blob/master/pomodoro_bitbar.rb 😄

from xbar-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.