Use a char array for passwords about jraw HOT 4 CLOSED

I would be happy to pick up this enhancement.

I also believe that any requests we send that include a password should not be stored in the request history which the API maintains, or at the very least the secure request parameters should be sanitized/removed.

Future API enhancements (such as http://www.reddit.com/dev/api#POST_api_update_password) require passwords to be sent as a request parameter.

A possible work around could also be to perform a API request as per the http://www.reddit.com/dev/api#POST_api_login which bypasses storing a request history.

I do not have the code base open so I am not able to reference JRAW's methods / variable names exactly but I hope this is clear enough.

Thoughts?

from jraw.

My first thought would be to include a flag in the RestRequest class for if it contains a password, and then add it to the history if that flag is false.

However, I have been working on migrating JRAW from Apache's HttpComponents to Square's much simpler OkHttp so that this library can focus more on high-level networking instead of having to maintain the mini-framework wrapped around HttpComponents. This issue might best be left unresolved until that time which I expect to be by Thursday, Friday at the very latest.

from jraw.

I finished the switch. You can find the commit here.

from jraw.

Closing in favor of #18

from jraw.