Passing existing *sql.DB to migrate about migrate HOT 7 CLOSED

Interesting idea! Would you still call Close() on the db object?

from migrate.

In my particular use case (integration tests), yes, after all tests are done I would call Close(). But that should be the responsibility of the caller, migrate shouldn't close a connection it didn't open by itself.

from migrate.

+1

from migrate.

@mattes Would you be willing to merge a PR for this?

from migrate.

I would have liked this, as I already had code to locate a database and set up a connection pool using non-URI connection strings. I ended up having to refactor to use URIs in order to avoid unnecessary extra code.

from migrate.

Can this be merged? I need this workflow too. Thanks.

from migrate.

Closing this in favor of #120

from migrate.