[QUESTION] Some small features - are they needed to PR? about minify HOT 3 CLOSED

Hey @vladimmi

I've been thinking about it.
I definitely like the gzip idea, although I wouldn't do it as part of minify() function. How about creating a new method in Minify.php? Something along these lines:

public function gzip($path, $level = 9)
{
    $content = $this->execute($path);
    $content = gzencode($content, $level)

    // save to path
    if ($path !== null) {
        $this->save($content, $path);
    }

    return $content;
}

What do you think about this?

I also like the other idea, I'm just not really sure it belongs in minifier :p I'll think about that some more.

from minify.

How about creating a new method in Minify.php?

Sure, you are free to do it as you wish 👍

I also like the other idea, I'm just not really sure it belongs in minifier :p

That's why I decided to ask before starting to make tests and PR :) Pretty similar to image embedding (make one bigger file instead of many small requests) but... Got some troubles while thinking about that idea:

1. unlike CSS, such JS code doesn't work without minifier. So it becomes something like builder, not just minifier. Wasn't problem for my project but can be for others.
2. that can be workarounded but needs some additional JS code. Like var template = Foo.load('path/to/file'); and use that call as directive to embed template. But used paths can be relative to script (which are impossible to resolve from browser, as I know) or relative to root (and we need to set some root path to find them in minifier, making usage harder)...

Maybe you'll have some inspiration and better ideas :)

from minify.

Just included gzip() method in 30a4592 - thanks for the idea!

I'm not going to go ahead with the other idea, for exactly the same reasons you already listed - haven't been able to come up with great solutions myself :)

from minify.