Comments (6)
matthieugrieger
commented on May 27, 2024
Hi!
Thanks for the bug report. I think I just forgot to remove some panic statements from when I was testing the bot. This commit should hopefully fix it: 5d91ca9. Let me know if it works!
from mumbledj.
MrKrucible
commented on May 27, 2024
Sorry for the late response but I tested it out and it's fixed!
from mumbledj.
MrKrucible
commented on May 27, 2024
Whoa, hold up one sec...
Some friends just double skipped while a song is playing, and that crashes the bot too. Tested it out and it's a related bug.
EDIT: almost forgot to add the dump...
kirk@kirk:~/git/mumbledj$ mumbledj -server=mumble.justsomegamers.com -port=6052 -username=Data -password="" -channel=M
Channel doesn't exist or one was not provided, staying in root channel...
Configuration successfully loaded!
panic: An error occurred while adding a skip to the current song.
goroutine 5 [running]:
main.skip(0xc208040e00, 0xc208102270, 0xa, 0x0)
/home/kirk/gittest/mumbledj/commands.go:224 +0xf0a
main.parseCommand(0xc208040e00, 0xc208102270, 0xa, 0xc208102579, 0x4)
/home/kirk/gittest/mumbledj/commands.go:45 +0x317
main.(*mumbledj).OnTextMessage(0xc28760, 0xc20810d420)
/home/kirk/gittest/mumbledj/main.go:69 +0xce
main.*mumbledj.OnTextMessage·fm(0xc20810d420)
/home/kirk/gittest/mumbledj/main.go:117 +0x31
github.com/layeh/gumble/gumbleutil.Listener.OnTextMessage(0xc208028ac0, 0xc208028ad0, 0xc208028ae0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/home/kirk/go/src/github.com/layeh/gumble/gumbleutil/listener.go:44 +0x37
github.com/layeh/gumble/gumbleutil.(*Listener).OnTextMessage(0xc20802e320, 0xc20810d420)
<autogenerated>:3 +0xaa
github.com/layeh/gumble/gumble.eventMultiplexer.OnTextMessage(0xc20803b410, 0xc20803b440, 0xc20810d420)
/home/kirk/go/src/github.com/layeh/gumble/gumble/eventmultiplexer.go:62 +0x57
github.com/layeh/gumble/gumble.handleTextMessage(0xc20806e000, 0xc208031400, 0xb, 0x400, 0x0, 0x0)
/home/kirk/go/src/github.com/layeh/gumble/gumble/handlers.go:578 +0x917
github.com/layeh/gumble/gumble.(*Client).readRoutine(0xc20806e000)
/home/kirk/go/src/github.com/layeh/gumble/gumble/client.go:204 +0x613
created by github.com/layeh/gumble/gumble.(*Client).Connect
/home/kirk/go/src/github.com/layeh/gumble/gumble/client.go:108 +0x434
goroutine 1 [chan receive]:
main.main()
/home/kirk/gittest/mumbledj/main.go:128 +0x4ea
goroutine 17 [syscall, locked to thread]:
runtime.goexit()
/usr/local/go/src/runtime/asm_amd64.s:2232 +0x1
goroutine 6 [select]:
github.com/layeh/gumble/gumble.(*Client).pingRoutine(0xc20806e000)
/home/kirk/go/src/github.com/layeh/gumble/gumble/client.go:163 +0x2dc
created by github.com/layeh/gumble/gumble.(*Client).Connect
/home/kirk/go/src/github.com/layeh/gumble/gumble/client.go:109 +0x451
goroutine 12 [select]:
github.com/layeh/gumble/gumble_ffmpeg.(*Stream).sourceRoutine(0xc20802a640)
/home/kirk/go/src/github.com/layeh/gumble/gumble_ffmpeg/gumble_ffmpeg.go:89 +0x452
created by github.com/layeh/gumble/gumble_ffmpeg.(*Stream).Play
/home/kirk/go/src/github.com/layeh/gumble/gumble_ffmpeg/gumble_ffmpeg.go:47 +0x39d
goroutine 10 [IO wait]:
net.(*pollDesc).Wait(0xc20800efb0, 0x72, 0x0, 0x0)
/usr/local/go/src/net/fd_poll_runtime.go:84 +0x47
net.(*pollDesc).WaitRead(0xc20800efb0, 0x0, 0x0)
/usr/local/go/src/net/fd_poll_runtime.go:89 +0x43
net.(*netFD).Read(0xc20800ef50, 0xc2080fa000, 0x1000, 0x1000, 0x0, 0x7fc1f07c0d70, 0xc2080bd810)
/usr/local/go/src/net/fd_unix.go:242 +0x40f
net.(*conn).Read(0xc20802c088, 0xc2080fa000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
/usr/local/go/src/net/net.go:121 +0xdc
net/http.noteEOFReader.Read(0x7fc1f07c2290, 0xc20802c088, 0xc2080be108, 0xc2080fa000, 0x1000, 0x1000, 0x740d80, 0x0, 0x0)
/usr/local/go/src/net/http/transport.go:1270 +0x6e
net/http.(*noteEOFReader).Read(0xc20801cba0, 0xc2080fa000, 0x1000, 0x1000, 0xc208010000, 0x0, 0x0)
<autogenerated>:125 +0xd4
bufio.(*Reader).fill(0xc20800a9c0)
/usr/local/go/src/bufio/bufio.go:97 +0x1ce
bufio.(*Reader).Peek(0xc20800a9c0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0)
/usr/local/go/src/bufio/bufio.go:132 +0xf0
net/http.(*persistConn).readLoop(0xc2080be0b0)
/usr/local/go/src/net/http/transport.go:842 +0xa4
created by net/http.(*Transport).dialConn
/usr/local/go/src/net/http/transport.go:660 +0xc9f
goroutine 11 [select]:
net/http.(*persistConn).writeLoop(0xc2080be0b0)
/usr/local/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
/usr/local/go/src/net/http/transport.go:661 +0xcbc
from mumbledj.
matthieugrieger
commented on May 27, 2024
Are you sure you updated to the newest release? The dump doesn't really make sense with the code in its current state... According to the log the panic supposedly happens at /home/kirk/gittest/mumbledj/commands.go:224, which is located here.
Comparing this with the commit from earlier (5d91ca9), it makes me think that you're still on the older release since in that case line 224 can cause a panic.
from mumbledj.
MrKrucible
commented on May 27, 2024
Damn, wasn't paying attention and didn't see the 5d91ca9 commit! Got the new version up and all is well, so thanks for clarifying on that.
from mumbledj.
matthieugrieger
commented on May 27, 2024
No problem! Glad it's working now.
from mumbledj.
Related Issues (20)
- The audio download for this video failed. <the video> has likely not generated the audio files for this track yet. HOT 2
- Problem with youtube links HOT 2
- panic: runtime error: slice bounds out of range HOT 10
- Pine64 config file and command arguments ignored. HOT 9
- Bot crashed after mumble restart HOT 4
- [Feature Request] Default Playlist File HOT 3
- Queue not playing next songs and bot partially responding to commands HOT 17
- Disconnecting right after connecting HOT 15
- Soundcloud plays only the first song HOT 2
- [error] - certificate signed by unknown authority HOT 3
- configuration file set to avconv not looking for avconv HOT 6
- Question about server certificates. HOT 5
- Go Panic HOT 2
- Go Panic (second edition) HOT 4
- Skip feature HOT 2
- Continuous playback/loop feature HOT 1
- Go panic (unknown edition) HOT 3
- Go Panic (dual edition)
- Support For MultiUser Environments HOT 1
- MumbleDJ will not take commands or read configs (intel based system) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mumbledj.