Giter VIP home page Giter VIP logo

Comments (13)

matthieugrieger avatar matthieugrieger commented on May 27, 2024

Good ideas!

The shuffle mode is cool, but due to the nature of the data structure I use to represent the queue it wouldn't be (easily) possible to make it so that the queue is always shuffled. Probably the more realistic approach would be to add a !shuffle command that shuffles the items that are already in the queue (meaning that any songs added after !shuffle would not be shuffled until the command is used again).

The radio mode is also another good idea. Once the shuffle mode is implemented this would be fairly easy to implement, and I may be able to incorporate it with another idea I have been considering (allowing admins to save songs permanently).

from mumbledj.

hamilton5 avatar hamilton5 commented on May 27, 2024

The queue always being shuffled just does not make any sense. !shuffle would work well with playlists..

from mumbledj.

bryanh-9 avatar bryanh-9 commented on May 27, 2024

Don't believe anyone said it should always be shuffled. The always comment was for the "radiomode" idea I had outlined.

from mumbledj.

hamilton5 avatar hamilton5 commented on May 27, 2024

!repeat ? when turned on the current queue is looped !add is blocked until repeat is turned off..

from mumbledj.

 avatar commented on May 27, 2024

that makes sense to me...

from mumbledj.

tcaruth avatar tcaruth commented on May 27, 2024

just wanted to throw out there, i would use a radio mode for sure.

currently my users just have full youtube playlists and add 25 at a time, but eventually (inevitably while mid-game) the playlist will end. i'm not familiar enough with go to be of any assistance however 😧

from mumbledj.

gplassard avatar gplassard commented on May 27, 2024

Hi, first, thanks for your awesome work!

I tried to implement a pretty simple mechanism for shuffling but I'm pretty new to go so any comment would be welcome 03a51ed

from mumbledj.

matthieugrieger avatar matthieugrieger commented on May 27, 2024

@GabrielPlassard: Thanks for doing this! I left a comment on the commit. Set up a PR and I'll test & merge it!

from mumbledj.

gplassard avatar gplassard commented on May 27, 2024

Actually, I used it a bit and I think @Nariaftw idea with !shuffleon and !shuffleoff makes more sense (at least for my use case). So I'm gonna have a look and try to implement it.
Do you prefer 2 separates PRs or only 1 when I'm ready?

from mumbledj.

matthieugrieger avatar matthieugrieger commented on May 27, 2024

@GabrielPlassard I think one PR would be fine. Are you keeping the !shuffle command as well? I think having both options would be cool.

from mumbledj.

gplassard avatar gplassard commented on May 27, 2024

As long as you think there is a use case for it, I don't see any reason to remove it :)

from mumbledj.

matthieugrieger avatar matthieugrieger commented on May 27, 2024

@GabrielPlassard Keep it then. I know that the people on my server would probably use it!

from mumbledj.

matthieugrieger avatar matthieugrieger commented on May 27, 2024

Closing this issue as shuffle has been implemented. I don't foresee implementing a radio mode any time in the near future.

from mumbledj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.