spawn, events, overallProgress info about node-rsync HOT 3 CLOSED

Thanks for your input. I agree on the buffering of output, this can be dangerous. I'll change the code to not buffer the output and only pass it to the output handlers.

On output handlers, these are already available in master (have not released a new version yet) so adding events will not add any functionality, you can already capture and parse the output by assigning output handlers through the output method. I'll add an example to the repository to demonstrate this.

I want to keep parsing the rsync command's output out of this library because the output is heavily dependent on how the command was build and with what options. It is not possible to set up output parsing for every possible combination of parameters so I want to leave that in the hands of the programmer who configured the command. The output handlers can be used to get the output and parse it for the configured command. Sending events should also be done from the implementing code if this is desired.

I'm still working out if exec is better than spawn, I think you want the sub-process to keep running when the main process is killed to prevent partially transferred file lists.

from node-rsync.

Okay the output handlers are fine for me.
But working with exec makes it very difficult to send SIGTERM or other kill-signals to rsync. NodeJS kills only the subshell (sh) and rsyn runs furthermore. AND exec everytime buffers all std(in|out)!
So i think using spwan is the only way to go. To be correct i think its good and necessarry to kill rsync if the main-process dies!

from node-rsync.

I can agree on the fact that spawn would be better because of the buffering, but the argument that exec makes sending SIGTERM signals to the process harder is kind of weak. It does not make it harder, it just makes it different. You can still use standard tools (like kill on Unix) to end the process, it's just not same as pressing CTRL-c to end the parent node process.

I will change the default behaviour to spawn because the buffer point is valid and it's important to have solid default behaviour for the library. I do value the option to detach the process so it will keep running if the parent dies. I'll figure out another way to do this, probably with something like an executeDetached method.

I'll try to update the code this week to use spawn and hopefully release a new version. Thanks for your feedback.

cheers

from node-rsync.