Comments (6)
There are still two todos in clipPolygon3dHP
- What is the output if the plane is same as polygon plane?
- Rename this function to 'clipPolygon3d'
from matgeom.
Two questions remain:
What should be the output if the plane is same as polygon plane?
Should we rename this function to: clipPolygonByPlane3d?
Maybe reopen till final decision?
from matgeom.
Yes, I agree.
my opinion about the two questions:
- if plane is the same as polygon plane, this should return the same polygon. If I had to start from scratch I would maybe rather throw an error. However, several functions in MatGeom return default values (like NaN or Inf) in similar cases. It seems preferable to be consistent with the existing.
- For renaming: yes, cleary more obvious!
best,
David
from matgeom.
Sounds good!
One more question.
Before processing the input polygon it is checked if all points are in a plane. What tolerance would you use here? At the moment it is. 1e-8. But maybe you use some other (default) tolerance in other functions?
Kind regards
from matgeom.
Sounds good!
One more question. Before processing the input polygon it is checked if all points are in a plane. What tolerance would you use here? At the moment it is. 1e-8. But maybe you use some other (default) tolerance in other functions?
Kind regards
I've changed it to 1e-14 now.
from matgeom.
Hi,
there is no absolute default for tolerance within the library. I often use 1e-8, but other functions use 1e-12. Value 1e-14 is fine as well for me.
The problem is that this often depends on the range of input data. I usually try to make the tests on normalized values, but there stille may be some uncoverd cases;
from matgeom.
Related Issues (20)
- Standardization of the header HOT 20
- Move graphs\grSimplifyBranches_old.m to deprecated\graphs ? HOT 1
- Bugs in intersectEdges.m HOT 2
- Delete changelog.txt(s) ? HOT 4
- Move data files to subfolder or data folder? HOT 1
- medialAxisConvex is not fully implemented
- Plotting a vector of circles only plots the final circle in the vector HOT 4
- Rename clipPolygonHP to clipPolygonByLine? HOT 1
- Missing functions in Contents.m HOT 1
- Missing polygons2d.m HOT 4
- Rename clipMeshVertices to cutMeshVertices?
- vertexNormal duplicate of meshVertexNormals? HOT 1
- Rename polyhedronSlice to intersectPlaneConvexPolyhedron?
- Matgeom - verLessThan: package "matlab" is not installed HOT 2
- polynomialCurves2d: No such file or directory HOT 1
- drawCircle3d.m function in matgeom package return error : "matlab" package not instaled
- drawPlane3d function in matgeom package return error
- drawArrow.m why axis equal? HOT 3
- fitEllipse sometimes computes wrong angles HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from matgeom.