Comments (6)
mattwebbio
commented on June 7, 2024
1
Merged and bumped to 1.4! Thanks again for your contribution, @cbundy :)
from orbital-sync.
mattwebbio
commented on June 7, 2024
Hi! I would gladly accept a pull request for this. I think the best approach might be to add optional PRIMARY_HOST_PATH and SECONDARY_HOST_(#)_PATH options that default to /admin. How do you feel about this?
The other option could be to replace PRIMARY_HOST_BASE_URL with a singular PRIMARY_HOST_URL that includes the path (i.e. http://10.0.0.2/admin), but this would be a breaking change.
from orbital-sync.
cbundy
commented on June 7, 2024
Yes, agree with your idea of optional path. Probably not too common and avoiding a breaking change is ideal.
from orbital-sync.
cbundy
commented on June 7, 2024
I've created a PR #68 , would love your feedback
from orbital-sync.
mattwebbio
commented on June 7, 2024
I've created a PR #68 , would love your feedback
This is awesome! It looks like you've put quite a bit of time into this. I really appreciate it! I'm AFK this weekend but I'll try to look at it some time this coming week 😊
from orbital-sync.
cbundy
commented on June 7, 2024
Awesome, thanks, pleasure to work with you and happy to do it again sometime
from orbital-sync.
Related Issues (20)
- Syncs are failing with the latest pihole update HOT 7
- Successfull sign in but failure at download backup HOT 10
- Fetcherror
- Support passwordless pihole installations HOT 3
- Unable to Connect to PI-Hole on same Docker Instance HOT 6
- Failure: No token could be found while logging in to "http://10.0.40.5/admin" - are you able to log in with the configured password? HOT 2
- MODULE_NOT_FOUND sync.js HOT 3
- [Feature Request] Sync advanced DNS settings HOT 1
- Pihole V6
- Ability to sync config to cloud for backup
- Whitelists not syncing HOT 1
- SMTP is misconfigured HOT 13
- Implement Health Status
- Unable to sync third secondary pihole HOT 2
- Group management status not synchronized to second pi-hole HOT 2
- ERR_MODULE_NOT_FOUND. Sync.js not found HOT 1
- Update "latest" tag on Docker Hub HOT 4
- [RFE] Notifications via apprise HOT 1
- new docker install 1.6 wont start HOT 3
- Set TZ for correct show log time and format HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orbital-sync.