Giter VIP home page Giter VIP logo

Comments (8)

MatviiB avatar MatviiB commented on May 25, 2024

Yes, BUT if i change N in data.id.includes(N) i can see not mine data

from notifier.

AEK-BKF avatar AEK-BKF commented on May 25, 2024

No! you should not change it there, but you can change in $suersID
here : $userID = [1,2,3];
It works fine for me, just create two users, and set one userID. you'll receive notification for just this one.

from notifier.

MatviiB avatar MatviiB commented on May 25, 2024

i mean this is vulnerability

from notifier.

AEK-BKF avatar AEK-BKF commented on May 25, 2024

Ok I updated it :
in app.js :

socket.addEventListener('message', function (event) {
        if(JSON.parse(event.data).data.id.includes(window.Laravel.userID))
        {
            toastr.info(JSON.parse(event.data).data.content, JSON.parse(event.data).data.title);
        }
    });

In main blade:

<script>
       window.Laravel = {!! json_encode([
           'csrfToken' => csrf_token(),
           'userID' =>  auth()->id()
       ]) !!};        
   </script>

Of course you should install node & npm and then run : npm run dev

May this helps ^^'

from notifier.

MatviiB avatar MatviiB commented on May 25, 2024

i don't understand 😀
it still vulnerability.
should "think" a way without any id on client side logic

from notifier.

AEK-BKF avatar AEK-BKF commented on May 25, 2024

No ! it's Laravel way to use Vue.js !
this code :

socket.addEventListener('message', function (event) {
        if(JSON.parse(event.data).data.id.includes(window.Laravel.userID))
        {
            toastr.info(JSON.parse(event.data).data.content, JSON.parse(event.data).data.title);
        }
    });

doesn't appear in client side !

from notifier.

AEK-BKF avatar AEK-BKF commented on May 25, 2024

Otherwise we're waiting for you to get a solution for this and also to send notifier to all urls ^^'

from notifier.

MatviiB avatar MatviiB commented on May 25, 2024

Hi. you can review last release.
now you need to add @include('notifier::connect') to your main layout to use it on all pages.
and without this including client will not connect to socked server at all, i removed auto connection.

from notifier.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.