Giter VIP home page Giter VIP logo

Comments (25)

maxgalbu avatar maxgalbu commented on June 15, 2024

Which game?

from xbmc.plugin.video.nba.

Aquassaut avatar Aquassaut commented on June 15, 2024

OKC vs Philadelphia (game from 2016-10-26, tried to watch it on 2016-10-27 well after the end of the game)

from xbmc.plugin.video.nba.

dav-sap avatar dav-sap commented on June 15, 2024

Hey maxgalbu,
First of all thanks for everything. the addon is great. I'm having the same issue as Aquassaut, after the games end, it takes a while until you can actually go and watch them from the beginning. It happened to all the games I tried to watch from last night, which finished 2-5 hours before.
It probably comes from the same issue as starting a game from the beginning even though it's in the middle. ( i haven't figured a way to do that).
Thanks for all the help

from xbmc.plugin.video.nba.

itzeddie avatar itzeddie commented on June 15, 2024

There seems to be somewhere a 5000kbps bitrate available, I am seeing a number of the dodgy downloads online showing 5000kbps.

from xbmc.plugin.video.nba.

besarbb avatar besarbb commented on June 15, 2024

maxgalbu, is there a way of fixing this "Game ended" screen that stays there for more than two hours after the game is over until it is actually available for us to watch it? I usually want to watch the games during the mornings just before going to school, but until now, all I can watch are the afternoon games.

It would be simply perfect if the game would be available as soon as it was so in nba.com.

Thanks so much for the add-on :)

from xbmc.plugin.video.nba.

itzeddie avatar itzeddie commented on June 15, 2024

I am seeing this again this evening, I can load the games fine on my phone but I only get the live feed which now shows game ended on Kodi.

from xbmc.plugin.video.nba.

besarbb avatar besarbb commented on June 15, 2024

All these games are still not available from last night:
Spurs vs Clippers
Cavs vs Sixers
Kings vs Bucks
Thunder vs Wolves

I am checking the add-on like crazy, just like I am trying to not stumble upon spoilers :(
All we're getting for these games is "GAME ENDED".

from xbmc.plugin.video.nba.

maxgalbu avatar maxgalbu commented on June 15, 2024

Looks good to me now... Unfortunately I can't try to fix it if I don't have the issue

from xbmc.plugin.video.nba.

besarbb avatar besarbb commented on June 15, 2024

Yeah, they became available about an hour after I posted...

from xbmc.plugin.video.nba.

besarbb avatar besarbb commented on June 15, 2024

There is Jazz vs Knicks right now with the same problem. This game should have actually only ended about 1-2 hours ago, but now it is in archive, and it won't play, with the screen being stuck at "GAME ENDED".

EDIT: It is good now. I guess if you'd like to actually see this problem, you will have to check the add-on during morning hours(CET time). Cheers mate :)

from xbmc.plugin.video.nba.

itzeddie avatar itzeddie commented on June 15, 2024

The Spurs vs. Rockets game from today (12th) is currently exhibiting this @maxgalbu if you want to have a look.

from xbmc.plugin.video.nba.

maxgalbu avatar maxgalbu commented on June 15, 2024

I've checked this morning, and there were some games in that "condition", but I couldn't play them from the ipad (The selected game is not available). The ipad "method" of playing games (hls stream) is the one used in the plugin, because xbmc apparently doesn't support adaptive streams (or requires cookies in all the requests, I can't remember), which are used in the website flow (adaptive streams). I guess it's only possible from the adaptive stream, and not using HLS streams...

from xbmc.plugin.video.nba.

besarbb avatar besarbb commented on June 15, 2024

So, do you think you can somehow "integrate" those adaptive streams into the add-on?

I am sorry for being so noisy btw, I just am a big nba fan and I can't help it :(.

from xbmc.plugin.video.nba.

Miss80 avatar Miss80 commented on June 15, 2024

@besarbb I've reported the same issue this weekend with the Celtics game in the kodi forum. 9.40 AM in the netherlands. You are not the only noisy person ;-)

from xbmc.plugin.video.nba.

besarbb avatar besarbb commented on June 15, 2024

Is there something being done about this? It's 1:30pm in CET, and Clippers@Cavaliers is still not available to watch. :(

from xbmc.plugin.video.nba.

besarbb avatar besarbb commented on June 15, 2024

Is it just me or there is not even one game playable from last night's games?

from xbmc.plugin.video.nba.

salvatoreorange avatar salvatoreorange commented on June 15, 2024

It's not just you.

from xbmc.plugin.video.nba.

a7ypically avatar a7ypically commented on June 15, 2024

@maxgalbu When a live game ends, before it is edited, you have to pass the starting time and duration to get the full stream when requesting the game URL. Otherwise you only get the end of stream which is the issue that is reported here.

in getGameUrl you need to add something like:

if gs == 2 and not live_game:
    body['st'] = str(st)
    body['dur'] = str(et - st)

getGameUrl needs to receive the st and et parameters.
You can get them in addGamesLinks:

if not live and st,et in game:
st = calendar.timegm(time.strptime(game['st'], '%Y-%m-%dT%H:%M:%S.%f')) * 1000
et = calendar.timegm(time.strptime(game['et'], '%Y-%m-%dT%H:%M:%S.%f')) * 1000

Sorry, I don't have a code for you to pull, but with this changes in place in a similar code, it works for me.

from xbmc.plugin.video.nba.

besarbb avatar besarbb commented on June 15, 2024

Hey @maxgalbu can we try what @a7ypically has suggested for the finals? I'd really appreciate that, as maybe I'll be able to watch the games unspoiled after I wake up... :)

from xbmc.plugin.video.nba.

dav-sap avatar dav-sap commented on June 15, 2024

Hey all,
I did make a few changes that might work. I added the option to start from beginning while the game is still going. Problem is there are no games until the finals, I have no way to check if it works.
It does not change anything with the archive games, so the addon whatever I can check right now works.
Any ideas for testing?

from xbmc.plugin.video.nba.

a7ypically avatar a7ypically commented on June 15, 2024

I don't think there's a way to test it.
I'm happy to review the code but I don't see a commit.

from xbmc.plugin.video.nba.

dav-sap avatar dav-sap commented on June 15, 2024

created a pull request, check it out
#52

from xbmc.plugin.video.nba.

a7ypically avatar a7ypically commented on June 15, 2024

Looks good to me and I think it should work. I added a comment about some safety checks you should probably add.
I did not check if you can play from the beginning while a game is live. Is that something LP allows on the web? I don't think I've seen this on mobile.

from xbmc.plugin.video.nba.

dav-sap avatar dav-sap commented on June 15, 2024

yea it works on the web and also on Android which i use, not sure regarding iPad, which the addon is based on. But I really don't know how the kodi will react to this, because it has no end time, it's why i need to run some tests. I'll try it out during the upcoming game.
I'll take a look at the comments.

from xbmc.plugin.video.nba.

dav-sap avatar dav-sap commented on June 15, 2024

Tested & works!
You can start any game from the beginning.
While the game is still on you will be able to start it from the beginning, however the duration of the game will be from the beginning till the present time- meaning it probably won't continue live, so I'm still working on solutions for that. ( I have been thinking what will happen if we just use duration of like 4 hours, will it continue live? probably not need to be checked, any ideas will be welcomed)
Any game in the archive will now start from the beginning no matter what.
Any game in the LIVE section, you can choose to start from the beginning, so games that ended half an hour ago, and are still in the live section you'll be able to watch no problems.

#52

from xbmc.plugin.video.nba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.