Giter VIP home page Giter VIP logo

Comments (8)

MaxHalford avatar MaxHalford commented on May 27, 2024 1

The PR's quality was really good, thanks a ton.

from chime.

MaxHalford avatar MaxHalford commented on May 27, 2024 1

I added status check enforcement in pull requests so that this doesn't happen again :)

from chime.

MaxHalford avatar MaxHalford commented on May 27, 2024 1

Ok cool! Once you're done I'll release a new version on PyPI :)

from chime.

paw-lu avatar paw-lu commented on May 27, 2024 1
  1. Update pyproject.toml and poetry.lock to support Poetry >=1.1.0 (so it will work with a fresh install of poetry in the CI)

#8 addresses the first part of this change.

from chime.

MaxHalford avatar MaxHalford commented on May 27, 2024 1

Tests are fixed, good job @paw-lu :)

from chime.

paw-lu avatar paw-lu commented on May 27, 2024

#6 attempts to implement this.

from chime.

MaxHalford avatar MaxHalford commented on May 27, 2024

@paw-lu the CI tests are failing, probably because poetry isn't used to install chime. Do you want to take a look?

from chime.

paw-lu avatar paw-lu commented on May 27, 2024

@paw-lu the CI tests are failing, probably because poetry isn't used to install chime. Do you want to take a look?

Did not notice the CI tests 😅, thanks for the heads up! Like you alluded, the test fails because the package is never installed in the CI.

It should be (hopefully) easy to fix. I'll split this up into two PRs:

  1. Update pyproject.toml and poetry.lock to support Poetry >=1.1.0 (so it will work with a fresh install of poetry in the CI)
  2. Change .github/workflows/tests.yml to use Poetry to install the package before running pytest

from chime.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.