Comments (8)
The PR's quality was really good, thanks a ton.
from chime.
I added status check enforcement in pull requests so that this doesn't happen again :)
from chime.
Ok cool! Once you're done I'll release a new version on PyPI :)
from chime.
- Update pyproject.toml and poetry.lock to support Poetry >=1.1.0 (so it will work with a fresh install of poetry in the CI)
#8 addresses the first part of this change.
from chime.
Tests are fixed, good job @paw-lu :)
from chime.
#6 attempts to implement this.
from chime.
@paw-lu the CI tests are failing, probably because poetry isn't used to install chime. Do you want to take a look?
from chime.
@paw-lu the CI tests are failing, probably because poetry isn't used to install chime. Do you want to take a look?
Did not notice the CI tests 😅, thanks for the heads up! Like you alluded, the test fails because the package is never installed in the CI.
It should be (hopefully) easy to fix. I'll split this up into two PRs:
- Update
pyproject.toml
andpoetry.lock
to support Poetry >=1.1.0 (so it will work with a fresh install of poetry in the CI) - Change
.github/workflows/tests.yml
to use Poetry to install the package before running pytest
from chime.
Related Issues (14)
- Can't hear any sounds on Pop! OS 20.04 HOT 7
- Add a material theme HOT 2
- Add the ability to be able to set a default theme HOT 1
- [enhancement] exit code parameter for cli HOT 3
- No sound, error: "aplay: not found" HOT 7
- Add chime to Conda/Anaconda command line actions HOT 1
- How to run chime on google colab? HOT 5
- Add a way to add optional arguments to run commands HOT 2
- moye moye
- chime soundboard is down HOT 5
- Calmcode Link HOT 1
- Support Poetry >=1.1.0 HOT 1
- Install package in GitHub workflows before running tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chime.