Giter VIP home page Giter VIP logo

Comments (13)

yuezk avatar yuezk commented on May 29, 2024 3

Hi, @killtheliterate I can reproduce it on my local environment now. The root cause is that this plugin is a conflict with the vim-polyglot plugin. The latter plugin embedded this plugin several days ago.

If you have both plugins installed and the vim-polyglot is ahead of vim-jsx-pretty, then the autoload functions will load from the vim-polyglot plugin. But since you have let g:polyglot_disabled = ['jsx'] in your vimrc file, the autoload scripts won't execute, which will cause the autoload functions missing.

There two workarounds for this issue:

  1. Move vim-jsx-pretty ahead of vim-polyglot.
  2. Or disable vim-jsx-pretty plugin, since vim-polyglot already have it.

from vim-jsx-pretty.

pbondoer avatar pbondoer commented on May 29, 2024 1

Can confirm, same issue on neovim.

from vim-jsx-pretty.

yuezk avatar yuezk commented on May 29, 2024

@killtheliterate @pbondoer Thanks for your feedback. But I cannot reproduce this issue with either vim or neovim. Can you help provide a minimal vimrc which can reproduce this issue?

from vim-jsx-pretty.

yuezk avatar yuezk commented on May 29, 2024

@killtheliterate @pbondoer Can you paste the output of :scriptnames command? Please also provide the version of vim or neovim.

from vim-jsx-pretty.

yuezk avatar yuezk commented on May 29, 2024

Hi, @killtheliterate @pbondoer Although I didn't reproduce this issue with my local environment, I find a specious code in the after/syntax/typescript.vim which may cause this problem. That is, we call the autoload functions at the top level in the typescript.vim, which is not recommended by the doc for :autoload:

Also note that if you have two script files, and one calls a function in the
other and vice versa, before the used function is defined, it won't work.
Avoid using the autoload functionality at the toplevel.

So I replaced it with a runtime command, which seems much better.

Can you help update this plugin on your environment and verify if this issue is fixed? Thanks.

from vim-jsx-pretty.

killtheliterate avatar killtheliterate commented on May 29, 2024

@yuezk I will try an update, and then paste back :scriptnames.

from vim-jsx-pretty.

killtheliterate avatar killtheliterate commented on May 29, 2024

Bumped to the latest version

Now getting:

Error detected while processing CursorMoved Autocommands for "<buffer=2>":
E117: Unknown function: jsx_pretty#comment#update_commentstring

output of :scriptnames:

  1: ~/.config/nvim/init.vim
  2: ~/.config/nvim/config/plugins.vim
  3: ~/.config/nvim/autoload/plug.vim
  4: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/filetype.vim
  5: ~/.config/nvim/.plugged/vim-fugitive/ftdetect/fugitive.vim
  6: ~/.config/nvim/.plugged/vim-polyglot/ftdetect/polyglot.vim
  7: ~/.config/nvim/.plugged/vim-polyglot/after/ftdetect/rspec.vim
  8: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/ftplugin.vim
  9: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/indent.vim
 10: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/syntax/syntax.vim
 11: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/syntax/synload.vim
 12: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/syntax/syncolor.vim
 13: ~/.config/nvim/config/color.vim
 14: ~/.vimrc_background
 15: ~/.config/nvim/.plugged/base16-vim/colors/base16-gruvbox-dark-hard.vim
 16: ~/.config/nvim/config/general.vim
 17: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/syntax/nosyntax.vim
 18: ~/.config/nvim/config/highlight.vim
 19: ~/.config/nvim/config/reveal.vim
 20: ~/.config/nvim/config/tabs.vim
 21: ~/.config/nvim/config/plugin-config/ale.vim
 22: ~/.config/nvim/config/plugin-config/coc.vim
 23: ~/.config/nvim/config/plugin-config/deoplete.vim
 24: ~/.config/nvim/config/plugin-config/dirvish.vim
 25: ~/.config/nvim/config/plugin-config/easy-align.vim
 26: ~/.config/nvim/config/plugin-config/fzf.vim
 27: ~/.config/nvim/config/plugin-config/lightline.vim
 28: ~/.config/nvim/config/plugin-config/polyglot.vim
 29: ~/.config/nvim/config/plugin-config/poppy.vim
 30: ~/.config/nvim/config/plugin-config/vim-move.vim
 31: ~/.config/nvim/.plugged/vim-dirvish/plugin/dirvish.vim
 32: ~/.config/nvim/.plugged/vim-diminactive/plugin/diminactive.vim
 33: ~/.config/nvim/.plugged/poppy.vim/plugin/poppy.vim
 34: ~/.config/nvim/.plugged/securemodelines/plugin/securemodelines.vim
 35: ~/.config/nvim/.plugged/editorconfig-vim/plugin/editorconfig.vim
 36: ~/.config/nvim/.plugged/vim-dirvish-git/plugin/dirvish_git.vim
 37: ~/.config/nvim/.plugged/lightline.vim/plugin/lightline.vim
 38: ~/.config/nvim/.plugged/auto-pairs/plugin/auto-pairs.vim
 39: ~/.config/nvim/.plugged/vim-easy-align/plugin/easy_align.vim
 40: ~/.config/nvim/.plugged/vim-move/plugin/move.vim
 41: ~/.config/nvim/.plugged/lightline-ale/plugin/lightline/ale.vim
 42: ~/.config/nvim/.plugged/rainbow_csv/plugin/rainbow_csv.vim
 43: ~/.config/nvim/.plugged/vim-signify/plugin/signify.vim
 44: ~/.config/nvim/.plugged/numbers.vim/plugin/numbers.vim
 45: ~/.config/nvim/.plugged/vitality.vim/plugin/vitality.vim
 46: ~/.config/nvim/.plugged/tcomment_vim/plugin/tcomment.vim
 47: ~/.config/nvim/.plugged/tcomment_vim/autoload/tcomment/deprecated.vim
 48: ~/.config/nvim/.plugged/vim-eunuch/plugin/eunuch.vim
 49: ~/.config/nvim/.plugged/vim-fugitive/plugin/fugitive.vim
 50: ~/.config/nvim/.plugged/vim-surround/plugin/surround.vim
 51: ~/.fzf/plugin/fzf.vim
 52: ~/.config/nvim/.plugged/fzf.vim/plugin/fzf.vim
 53: ~/.config/nvim/.plugged/coc.nvim/plugin/coc.vim
 54: ~/.config/nvim/.plugged/coc.nvim/autoload/coc/rpc.vim
 55: ~/.config/nvim/.plugged/coc.nvim/autoload/coc/util.vim
 56: ~/.config/nvim/.plugged/coc.nvim/autoload/coc/client.vim
 57: ~/.config/nvim/.plugged/ale/plugin/ale.vim
 58: ~/.config/nvim/.plugged/ale/autoload/ale/events.vim
 59: ~/.config/nvim/.plugged/vim-devicons/plugin/webdevicons.vim
 60: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/gzip.vim
 61: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/health.vim
 62: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/man.vim
 63: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/matchit.vim
 64: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/matchparen.vim
 65: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/netrwPlugin.vim
 66: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/rplugin.vim
 67: ~/.local/share/nvim/rplugin.vim
 68: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/shada.vim
 69: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/spellfile.vim
 70: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/tarPlugin.vim
 71: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/tohtml.vim
 72: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/tutor.vim
 73: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/plugin/zipPlugin.vim
 74: ~/.config/nvim/.plugged/lightline.vim/autoload/lightline.vim
 75: ~/.config/nvim/.plugged/coc.nvim/autoload/coc.vim
 76: ~/.config/nvim/.plugged/lightline.vim/autoload/lightline/tab.vim
 77: ~/.config/nvim/.plugged/lightline.vim/autoload/lightline/colorscheme/default.vim
 78: ~/.config/nvim/.plugged/lightline.vim/autoload/lightline/colorscheme/powerline.vim
 79: ~/.config/nvim/.plugged/lightline.vim/autoload/lightline/colorscheme.vim
 80: ~/.config/nvim/.plugged/lightline-ale/autoload/lightline/ale.vim
 81: ~/.config/nvim/.plugged/ale/autoload/ale/engine.vim
 82: ~/.config/nvim/.plugged/ale/autoload/ale.vim
 83: ~/.config/nvim/.plugged/rainbow_csv/autoload/rainbow_csv.vim
 84: ~/.config/nvim/.plugged/ale/autoload/ale/pattern_options.vim
 85: ~/.config/nvim/.plugged/vim-fugitive/autoload/fugitive.vim
 86: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/autoload/provider/clipboard.vim
 87: ~/.config/nvim/.plugged/ale/autoload/ale/cursor.vim
 88: ~/.config/nvim/.plugged/coc.nvim/autoload/coc/list.vim
 89: /private/var/folders/gm/0m1zjqt92m3dw0nxpj8lbsmc0000gn/T/coc-74465.vim
 90: /usr/local/Cellar/neovim/0.3.7/share/nvim/runtime/scripts.vim
 91: ~/.config/nvim/.plugged/vim-polyglot/ftplugin/typescript.vim
 92: ~/.config/nvim/.plugged/vim-polyglot/compiler/typescript.vim
 93: ~/.config/nvim/.plugged/vim-polyglot/after/ftplugin/typescript.vim
 94: ~/.config/nvim/.plugged/vim-jsx-pretty/after/ftplugin/typescript.vim
 95: ~/.config/nvim/.plugged/vim-polyglot/indent/typescript.vim
 96: ~/.config/nvim/.plugged/vim-polyglot/after/indent/typescript.vim
 97: ~/.config/nvim/.plugged/vim-jsx-pretty/after/indent/typescript.vim
 98: ~/.config/nvim/.plugged/vim-polyglot/syntax/typescript.vim
 99: ~/.config/nvim/.plugged/vim-polyglot/after/syntax/typescript.vim
100: ~/.config/nvim/.plugged/vim-jsx-pretty/after/syntax/typescript.vim
101: ~/.config/nvim/.plugged/vim-jsx-pretty/shared/jsx_syntax.vim
102: ~/.config/nvim/.plugged/vim-signify/autoload/sy.vim
103: ~/.config/nvim/.plugged/vim-signify/autoload/sy/util.vim
104: ~/.config/nvim/.plugged/vim-signify/autoload/sy/repo.vim
105: ~/.config/nvim/.plugged/ale/autoload/ale/util.vim
106: ~/.config/nvim/.plugged/ale/autoload/ale/linter.vim
107: ~/.config/nvim/.plugged/ale/ale_linters/typescript/eslint.vim
108: ~/.config/nvim/.plugged/ale/ale_linters/typescript/tslint.vim
109: ~/.config/nvim/.plugged/ale/autoload/ale/handlers/tslint.vim
110: ~/.config/nvim/.plugged/ale/ale_linters/typescript/tsserver.vim
111: ~/.config/nvim/.plugged/ale/ale_linters/typescript/typecheck.vim
112: ~/.config/nvim/.plugged/ale/ale_linters/typescript/xo.vim
113: ~/.config/nvim/.plugged/ale/autoload/ale/command.vim
114: ~/.config/nvim/.plugged/ale/autoload/ale/lsp_linter.vim
115: ~/.config/nvim/.plugged/ale/autoload/ale/handlers/tsserver.vim
116: ~/.config/nvim/.plugged/ale/autoload/ale/path.vim
117: ~/.config/nvim/.plugged/ale/autoload/ale/node.vim
118: ~/.config/nvim/.plugged/ale/autoload/ale/history.vim
119: ~/.config/nvim/.plugged/ale/autoload/ale/lsp.vim
120: ~/.config/nvim/.plugged/ale/autoload/ale/job.vim
121: ~/.config/nvim/.plugged/ale/autoload/ale/lsp/tsserver_message.vim
122: ~/.config/nvim/.plugged/vim-polyglot/autoload/jsx_pretty/comment.vim
123: ~/.config/nvim/.plugged/ale/autoload/ale/lsp/response.vim
124: ~/.config/nvim/.plugged/vim-signify/autoload/sy/highlight.vim
125: ~/.config/nvim/.plugged/vim-signify/autoload/sy/sign.vim
126: ~/.config/nvim/.plugged/coc.nvim/autoload/coc/task.vim

from vim-jsx-pretty.

yuezk avatar yuezk commented on May 29, 2024

@killtheliterate Try add let g:polyglot_disabled = ['jsx'] in your vimrc.

from vim-jsx-pretty.

yuezk avatar yuezk commented on May 29, 2024

Or disable the vim-polyglot plugin and try again. If it was that case, I will try to find a way to fix it.

from vim-jsx-pretty.

ipatch avatar ipatch commented on May 29, 2024

Can confirm,

  • disabling this plugin vim-jsx-pretty
  • installing / enabling vim-polyglot via minpac
  • and making certain,
let g:polyglot_disabled = ['jsx']

is not in any vim configuration files prevents this error from being displayed while still retaining syntax highlighting for JSX files.

from vim-jsx-pretty.

pbondoer avatar pbondoer commented on May 29, 2024

@yuezk I've moved vim-polyglot ahead in my own config. Thanks for your help!

from vim-jsx-pretty.

killtheliterate avatar killtheliterate commented on May 29, 2024

@yuezk thank you. It seems to be sorted now.

from vim-jsx-pretty.

killtheliterate avatar killtheliterate commented on May 29, 2024

Things described above resolved this, so closing.

from vim-jsx-pretty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.