Giter VIP home page Giter VIP logo

Comments (3)

grempe avatar grempe commented on September 27, 2024 1

Happy to have you resolve.

I think my use of require is more idiomatic.

I'm not sure if setting both values to true as the default is necessary.

https://pointjupiter.com/what-noopener-noreferrer-nofollow-explained/

Cheers

from eleventy-plugin-safe-external-links.

MaybeThisIsRu avatar MaybeThisIsRu commented on September 27, 2024 1

...and we're good - thanks @grempe!

from eleventy-plugin-safe-external-links.

MaybeThisIsRu avatar MaybeThisIsRu commented on September 27, 2024

Hi @grempe! 😊

Thank you for pointing this out! Would you like to open a PR or are you happy for me to fix this?

Personally I hand-wrote my config as follows, and didn't think to test this from the README:

        config.addPlugin(require("@hirusi/eleventy-plugin-safe-external-links"), {
		pattern: "https{0,1}://", // RegExp pattern for external links
		noopener: true, // Whether to include noopener
		noreferrer: true, // Whether to include noreferrer
		files: [
			// What output file extensions to work on
			".html"
		]
	});

from eleventy-plugin-safe-external-links.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.