useChannel performance optimization about use-pusher HOT 4 CLOSED

pusher-js is keeping the subscribed channels. https://github.com/pusher/pusher-js/blob/9152c97631d08d428d36ded807b8c81ef7c008d3/src/core/channels/channel.ts#L96. I will dig deeper on what happened after some time. Closing this down since I think this may not be directly related to the use-pusher library

from use-pusher.

Let me know if I can help with anything. Cheers

from use-pusher.

Hey @asimkt, thanks for bringing this up!

My understanding is that internally pusher-js maintains an object of channels the user is subscribed to. So calling useChannel('my-channel') in multiple places subscribes to the same channel, and callbacks (useEvent) are connected to the same subscription.

Additionally, this effect should only re-run (by design) when either;

• channelName (string) changes, in which case it should unsubscribe and resubscribe to the new channel name, or
• client (state) changes, which shouldn't happen too often (only, for example, when another authorizer is passed to it, in which case it needs to resubscribe).

Is this an issue that you're having, or just a proactive improvement? If the former, please provide a codesandbox that demonstrates the extra connections I can have a look at!

from use-pusher.

Seems like pusher-js is not keeping the object of channels and this leads to multiple different subscriptions.
In my case,

• The client is only rendered on top. (Like you said, not changing much)
• I'm trying to connect to the same channel name (same string) in different components.

And in the pusher debug console, I can see multiple connections happening. Let me try to create a sandbox.

from use-pusher.