Comments (4)
mpg
commented on June 7, 2024
1
Note: it's probably obvious, but while fixing this we should improve the documentation of sign, verify, decrypt, encrypt in order to explicitly document this.
from mbedtls.
mpg
commented on June 7, 2024
1
Yes, I think all 4 functions (sign, verify, decrypt, encrypt) need new tests and corresponding adjustments - I guess Gilles only added tests for 1 of them as a proof of concept.
from mbedtls.
valeriosetti
commented on June 7, 2024
Question: new test cases added by @gilles-peskine-arm on his branch check verify not sign. However looking at pk_wrap.c it seems to me that also rsa_sign_wrap() in the USE_PSA case needs adjustments, right?
from mbedtls.
gilles-peskine-arm
commented on June 7, 2024
Yes, all 4 functions are affected. I just wanted to confirm the bug and only had time to do one function.
To test mbedtls_pk_sign and mbedtls_pk_encrypt, which are randomized, it's sufficient to test the verify/decrypt functions with known data, and separately test that the sign/verify and encrypt/decrypt functions work when paired together.
from mbedtls.
Related Issues (20)
- Remove hkdf.c HOT 2
- Protect against spurious definitions of derived symbols
- 2.28 only: build broken when `check_config.h` is not included
- Missing include stdlib.h and stdio.h in some platform configurations
- MbedTLS v3.6.0 - Compilation errors and warnings HOT 1
- Implement tf_psa_crypto_config.py
- Adapt config.py to configuration file split
- Move shipped AES and SHA acceleration to PSA drivers
- Deduce MBEDTLS_BLOCK_CIPHER_NO_DECRYPT automatically
- Consider removing DES HOT 1
- MBEDTLS_ECDSA_DETERMINISTIC in a PSA world
- Fix the detection of not-supported mechanisms in systematically generated PSA tests
- Improve the detection of never-supported PSA mechanisms
- Fix automatically generated PSA test cases that are not executed
- CMake Python detection finds the wrong Python HOT 1
- Signature of mbedtls_ssl_get_own_cid is using MBEDTLS_SSL_CID_OUT_LEN_MAX instead of MBEDTLS_SSL_CID_IN_LEN_MAX
- Rename `MBEDTLS_PSA_P256M_DRIVER_ENABLED` as `PSA_CRYPTO_DRIVER_MBEDTLS_P256M` HOT 1
- Add API to parse DER signature and export R and S components HOT 3
- Error when building MbedTLS 3.6 with GCC with LTO HOT 3
- MbedTLS code style inconsistencies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mbedtls.