Comments (2)
Hey there @Blaaznar !
Thank you for your report! This has recently been fixed in this PR: #105
I've got this deployed now to the tool, here: http://mcg.mbitson.com/
Please let me know if you notice anything else! Thanks again!
from mcg.
Observing the latest source code, the issue is still present.
This piece of code shouldn't work at all:
case 'constantin':
var baseLight = tinycolor('#ffffff');
var baseDark = $scope.multiply(tinycolor(hex).toRgb(), tinycolor(hex).toRgb());
var baseTriad = tinycolor(hex).tetrad();
return [
getColorObject(tinycolor.mix(baseLight, hex, 12), '50'),
getColorObject(tinycolor.mix(baseLight, hex, 30), '100'),
getColorObject(tinycolor.mix(baseLight, hex, 50), '200'),
getColorObject(tinycolor.mix(baseLight, hex, 70), '300'),
getColorObject(tinycolor.mix(baseLight, hex, 85), '400'),
getColorObject(tinycolor.mix(baseLight, hex, 100), '500'),
getColorObject(tinycolor.mix(baseDark, hex, 87), '600'),
getColorObject(tinycolor.mix(baseDark, hex, 70), '700'),
getColorObject(tinycolor.mix(baseDark, hex, 54), '800'),
getColorObject(tinycolor.mix(baseDark, hex, 25), '900'),
getColorObject(tinycolor.mix(baseDark, baseTriad[4], 15).saturate(80).lighten(65), 'A100'),
getColorObject(tinycolor.mix(baseDark, baseTriad[4], 15).saturate(80).lighten(55), 'A200'),
getColorObject(tinycolor.mix(baseDark, baseTriad[4], 15).saturate(100).lighten(45), 'A400'),
getColorObject(tinycolor.mix(baseDark, baseTriad[4], 15).saturate(100).lighten(40), 'A700')
];
var baseTriad = tinycolor(hex).tetrad();
// this variable should be renamed to baseTetrad
.
baseTriad[4]
is still out of bounds and returns undefined
.
Still scratching my head how on earth does this work at all???
Btw, generated accent colors don't resemble much the default accent colors generated by Material algorithm (ie. red, indigo, blue...).
from mcg.
Related Issues (20)
- Website is down HOT 1
- Import any code you can export HOT 2
- add ability to define default/hues HOT 1
- out of bound exception HOT 1
- Export to Dart for Flutter HOT 1
- Please add text contrast to the generator
- Url Sharing Improvements
- Add Google's algorithm HOT 1
- Constantin algorithm : index out of range ? HOT 1
- Why does baseTriad[4] work? This is out of bounds. HOT 2
- Angular 2 scss output leads to error HOT 2
- Can you please add vue-material HOT 7
- material-ui next HOT 2
- [feature] Shareable link to color palette configuration HOT 3
- Different generator algorithms HOT 2
- Algorithm deviation - cannot reproduce MD palette color? HOT 5
- material-ui@next export issue HOT 2
- extract the algorithm into its own library and publish to NPM HOT 6
- Define accent palette HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mcg.