Giter VIP home page Giter VIP logo

Comments (7)

mcabbott avatar mcabbott commented on May 25, 2024

On master there's a quick attempt at a fix, much like you suggest: 7896059

The awkward bit about using Requires is that we can't let Pkg bound versions. But maybe this is simple enough to just work. Needs to be tested a bit more...

from tullio.jl.

jondeuce avatar jondeuce commented on May 25, 2024

Thanks for the quick response! Ahh yes, I see the problem, that's a bit of a sticky situation. Your fix appears to have worked for the original issue, but now I receive a similar warning when loading ForwardDiff:

┌ Warning: Error requiring ForwardDiff from Tullio:
│ LoadError: UndefVarError: SVec not defined
│ ...in expression starting at /home/.julia/packages/Tullio/JZOUh/src/grad/avxdual.jl:6

It seems like another small change should fix this, too; the culprit should be this line.

from tullio.jl.

mcabbott avatar mcabbott commented on May 25, 2024

Thanks for testing... mostly I should comment out the worked example in that file! With latest commit:

julia> using Tullio, ForwardDiff, LoopVectorization, Tracker

julia> r33 = rand(3,3);

julia> Tracker.gradient(x -> sum(@tullio y[i] := log(x[i,j])), r33)
([1.1394564210213642 2.1680893862937927 1.0559383908137436; 1.1351873479437349 6.481911983174566 14.998379183695935; 1.85023371959207 19.48339920489614 1.0349811616209528] (tracked),)

julia> Tracker.gradient(x -> sum(@tullio y[i] := log(x[i,j]) grad=Dual), r33)
([1.1394564210213642 2.1680893862937927 1.0559383908137436; 1.1351873479437349 6.481911983174566 14.998379183695935; 1.85023371959207 19.48339920489614 1.0349811616209528] (tracked),)

from tullio.jl.

chriselrod avatar chriselrod commented on May 25, 2024

You're not the first person to have issues from the renaming. It'd be nice if optional dependencies could specify bounds.

Maybe I should have defined:

const SVec = Vec

from tullio.jl.

jondeuce avatar jondeuce commented on May 25, 2024

Great - seems like everything is working on my end 👍.

@chriselrod I believe that would have been sufficient in this case, though cluttering up your package's namespace is not ideal. But as you say, specifying bounds on optional dependencies (and generally being able to test different versions of optional dependencies more easily) would be much better.

from tullio.jl.

AshtonSBradley avatar AshtonSBradley commented on May 25, 2024

so... what is the fix?

from tullio.jl.

mcabbott avatar mcabbott commented on May 25, 2024

@AshtonSBradley the solution is to use master for now, as in ] add Tullio#master. There's a fix but I wanted to test it a bit more carefully before tagging.

@chriselrod no problem at all, this is a pretty minimal level of hassle. Thanks for sorting out the 1.6 update.

from tullio.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.