Comments (5)
I did a test and it looks like there is a problem with translation itself. Basically, when element is shifted by 20% of it's size, threshold
(with value 0.5
) doesn't match the center point of the element. Solution here is to either animate only when the animation has ended or apply new threshold
for shifted elements. I will think about a fix for this problem.
from sal.
Thanks for catching this bug! It looks like wrong threshold
setting and I need to confirm it. I'll be back with patch as soon as possible.
from sal.
After trying out some fixes it seems you have to offset the threshold by 20% to make up for the translateY, not 100% working yet though.
from sal.
@mciastek any updates on how to solve this?
from sal.
I checked this bug and I need to find a way how to resolve it without adding too much complexity to sal.js
. To fix this I would need to let sal
know how certain element was translated and update the threshold
accordingly.
Here's a workaround for this problem. As Intersection Observer detects if specific amount of pixels are present in viewport, every time you translate the element, it's pixels are also translated. So to bypass this behaviour you need to wrap this element in a wrapper, which will be detected by sal
. Next you need to disable animations on the wrapper. Then you can apply animation to proper element. Here's a simple demo - https://codesandbox.io/s/nkolnk00n0.
I will try to come up with solution, but I'm open to any ideas.
from sal.
Related Issues (20)
- Possible to use Library on div class whitout data-attribute HOT 3
- Animations aren't working on Google Chrome, iOS
- Flicking bug when on the threshold of element HOT 4
- Element stay hidden, animation won't trigger when going to page through <NuxtLink /> HOT 2
- Attach animation to h3 with attributes HOT 1
- Feature Request: Add easing functions to `sal-*` custom properties
- element animated but not visible
- Sal elements on unsupported browsers are completely invisible
- Animations are not working on mobile
- Using sal.js with swiper
- Set default delay and easing in JavaScript
- Configurable scss HOT 3
- Accessibility note for animating text components HOT 1
- Using sal.js with WordPress Gutenberg blocks HOT 2
- Can't install the plugin
- The default timing function causes the CLS score to drop significantly in Lighthouse
- Feature Request
- Animations already ran on page load
- sal.js is not working with react. sal is not defined
- sal({...}) overwrites previous call options
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sal.