Recover from connection resets when iterating through playlist about pydora HOT 5 CLOSED

Could be that this is something that should be handled in either urllib3 or requests (also see urllib3/urllib3#367)

from pydora.

These types of errors should be handled by the HTTPAdapter in RetryingSession, or at least that was the theory. I'll try subclassing that to provide better error handling for this case.

from pydora.

I've been hacking on something at https://github.com/jcass77/pydora/blob/709904df881b5d96bf13b1d592d64db1214aedb5/pandora/transport.py#L27-L83

It uses a generic retry decorator to retry the call if the specified exception(s) occur. It is not HTTP session aware at all, so not sure if it will be suitable as a retry handler.

@mcrute is this approach worth considering or would you prefer to handle it differently?

from pydora.

That seems like a pretty good approach. The API is already aware of login timeout exceptions and will retry those so unless there's some other class of error that can't be fixed with a retry this should work.

You may also be able to simplify the logic by using a while loop and decrementing an integer like:

retries_left = 10
while retries_left > 0:
   ... retry ...
   retries_left -= 1

from pydora.

Merged #31

from pydora.