Giter VIP home page Giter VIP logo

Comments (15)

mdhiggins avatar mdhiggins commented on June 2, 2024 1

image

Unable to reproduce, also why would anyone ever do this

from centertaskbar.

asdsadsaasd12312132 avatar asdsadsaasd12312132 commented on June 2, 2024 1

Yes. It's perfect.

from centertaskbar.

asdsadsaasd12312132 avatar asdsadsaasd12312132 commented on June 2, 2024

https://streamable.com/ospdbz

As for why:

  1. ergonomics; putting items and text too low on the screen causes a tendency to tilt the head down, which causes neck strain if sustained for hours
  2. speed; it's faster to access the task bar when it's higher up than at the bottom

from centertaskbar.

mdhiggins avatar mdhiggins commented on June 2, 2024

Can you try updating to the latest release?

from centertaskbar.

asdsadsaasd12312132 avatar asdsadsaasd12312132 commented on June 2, 2024

It isn't fixed. https://streamable.com/9d5d5s

I spoke with another developer and he explained the caused as "If the taskbar(s) height goes over 200px then TaskbarX thinks the taskbar is vertical."

from centertaskbar.

asdsadsaasd12312132 avatar asdsadsaasd12312132 commented on June 2, 2024

I accidentally closed the issue. It should be open.

from centertaskbar.

mdhiggins avatar mdhiggins commented on June 2, 2024

So the assumption from taskbarX dev is incorrect, the taskbar vertical check, at least in my script which I think TBX borrowed, compares the width and height which should be fine here and I ran the numbers, it is

var horizontal = trayBounds.Width > trayBounds.Height;

What actually looks like the issue is is that the UI scale calculation is failing. This was kind of a sneaky calculation I came up with because the certain UI elements report a scaled height and others do not, so by comparing the two values the scale could be calculated on a per-monitor basis. The issue here is that its comparing the height of an individual icon and the taskbar, which gets progressively worse the higher you drag the taskbar (icon height stays constant, container goes up and up).

I can instead use the top and left positions instead of height and get around this shortcoming I think and in my tests it seems to be working

b947e2f

That should fix it

https://github.com/mdhiggins/CenterTaskbar/releases/tag/1.7

Let me know

I can't speak to the techniques TBX uses for scale calculation but I know it was an issue that I had solved early on and had passed the technique to that developer so it likely uses the same method and fails for the same reason

from centertaskbar.

mdhiggins avatar mdhiggins commented on June 2, 2024

Hm looks like the calculation isn't perfect, I'll need to mess around a bit more

from centertaskbar.

asdsadsaasd12312132 avatar asdsadsaasd12312132 commented on June 2, 2024

It isn't perfect but works sufficiently well. As seen, it isn't fully centred (the line is the centre).
image

from centertaskbar.

mdhiggins avatar mdhiggins commented on June 2, 2024

I'll explore some other options to see if I can calculate the UI scale more accurately

from centertaskbar.

mdhiggins avatar mdhiggins commented on June 2, 2024

https://github.com/mdhiggins/CenterTaskbar/releases/tag/1.7b

Alternate solution, seems like a more perfect calculation now

783a8fa

from centertaskbar.

asdsadsaasd12312132 avatar asdsadsaasd12312132 commented on June 2, 2024

It looks identical to version 1.7a with imperfect centering to me. https://imgur.com/a/cQ8AKfN

from centertaskbar.

mdhiggins avatar mdhiggins commented on June 2, 2024

Is the centering perfect when it's not stretched out?

from centertaskbar.

asdsadsaasd12312132 avatar asdsadsaasd12312132 commented on June 2, 2024

No. It's slightly to the left.
Screenshot_2

from centertaskbar.

mdhiggins avatar mdhiggins commented on June 2, 2024

Found a couple little issues with padding that appears to have been added in later windows versions so I added some calculations to monitor for that in the future
Its a bitch to get it to scale with DPI but think I got it about as accurate as I can

https://github.com/mdhiggins/CenterTaskbar/releases/tag/1.8

See if that's better

from centertaskbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.