ndp.Dial uses (*icmp.PacketConn).SetChecksum which is not implemented on Windows about ndp HOT 4 CLOSED

I just noticed that the second possible solution is closely related to #10. So maybe both issues can be resolved together.

from ndp.

Option 3 seems reasonable to me for now, though honestly I have no idea which other parts of x/net/* work on Windows as I am on *nix 99% of the time. A PR would be welcome for that option.

As for #10, I'll think on that some more but don't plan to do it immediately. Thanks!

from ndp.

Okay I can submit a PR. But first, could you tell me why SetChecksum is called in the first place? If this call is needed for functionality other than router advertisements, this change could be a bad idea because it would imply that the library works with Windows when it fact it does not. Again, I only tested router advertisements after removing the call as this is my only usecase. If the checksum is optional then option 3 would indeed be fine and I'll submit the PR. I just don't want to introduce anything that makes this library worse.

from ndp.

Honestly I consider Windows support for any of my libraries to be best effort and would rather not change any existing functionality for Unix. It's been a long time since I've reviewed this code so let's make the minimum change to get Windows working and leave everything else alone for now.

from ndp.