Add a warning/suggestion to canvas.toDataURL to prefer toBlob about content HOT 3 OPEN

This is a good idea, but I'd be tempted by a warning box rather than just a note.

@evilpie Is there an approximate image size in some meaningful unit (pixels?) at which we can tell people they really need to worry? Or is it a matter that always recommending via toBlobUrl makes sense?

from content.

Hello @evilpie / @hamishwillee , Can I pick this issue? Please note that, I am starting to contribute to OpenSource for the very first time :)

from content.

@evilpie Is there an approximate image size in some meaningful unit (pixels?) at which we can tell people they really need to worry? Or is it a matter that always recommending via toBlobUrl makes sense?

I'm not @evilpie but I'd suggest just always recommending toBlobUrl. data URIs, even at smaller sizes, mean that the browser has to keep a copy of the data as a string (as you can call getAttribute on the image where you assign to src, or read its src property), which duplicates the contents of the data. Even though a 1MB data URI "works" pretty well in browsers, it's a lot of data that the browser has to copy around in memory etc. blob URIs are always more efficient.

Of course data URIs have their place for e.g. 1x1 pixel things but as long as any warning isn't overbearing that seems fine to me.

from content.