Comments (4)
At11011
commented on July 20, 2024
1
@At11011 FYI, the usual workflow is this: you open an issue -> you send a PR -> in the PR description, you say "fixes #34121" -> when that PR gets merged, this issue will be automatically closed. You only close the issue when the issue is actually fixed, not when the PR is still open.
Thank you, I'll do that next time.
That was actually my first pull request to a large public repo, I appreciate your guidence and promptness.
from content.
bsmth
commented on July 20, 2024
Thanks for raising this one. Would you like to open a PR to fix it?
from content.
At11011
commented on July 20, 2024
Thanks for raising this one. Would you like to open a PR to fix it?
Sure thing, I opened one here:
#34131
Thanks!
from content.
Josh-Cena
commented on July 20, 2024
@At11011 FYI, the usual workflow is this: you open an issue -> you send a PR -> in the PR description, you say "fixes #34121" -> when that PR gets merged, this issue will be automatically closed. You only close the issue when the issue is actually fixed, not when the PR is still open.
from content.
Related Issues (20)
- Remove CanvasRenderingContext2d scrollPathIntoView
- Standalone pages for Sec-WebSocket-* headers
- New pages for two new(ish) UA CH headers
- New page for Service-Worker-Allowed
- Animation playback events have not been covered
- Font color is to white HOT 1
- [CSS] Screenshots of examples in `box-decoration-break` can be embedded as live samples instead HOT 1
- Title cut off in Relative Colors > Color Scheme example
- Cache API is listed as a Service Worker API, but the API is not specific to Service Workers HOT 5
- inset-area is now renamed to position-area HOT 1
- Using URLSearchParams.delete method changes the enconding of unrelated search params HOT 1
- Pointer Events incoherence HOT 5
- Line-height does not mention vertical text
- Document WebAssembly integration with BigInt
- Typo: React interactivity: Editing, filtering, conditional rendering HOT 1
- Missing autocomplete contact token values
- Enhancement: Open external links in a new tab HOT 3
- Behavior of colors in gradient-images differes between browsers HOT 3
- Descriptions of orientation values missing HOT 1
- IsStandaloneContent does not work with `display: fullscreen` in Chrome Android
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from content.