Missing table tags about django-locallibrary-tutorial HOT 6 CLOSED

This is probably correct/better - but fwiw the tutorial does work with Django 2.0/recent versions.

from django-locallibrary-tutorial.

The django docs link above is for django 2.0, and still requires that we need to provide the <table> tag

from django-locallibrary-tutorial.

and just to confirm, tried now with django 2.0, still table not rendered if <table> tag is not provided

from django-locallibrary-tutorial.

source code:
https://github.com/django/django/blob/master/django/forms/forms.py#L277

    def as_table(self):
        "Return this form rendered as HTML <tr>s -- excluding the <table></table>."
        return self._html_output(
            normal_row='<tr%(html_class_attr)s><th>%(label)s</th><td>%(errors)s%(field)s%(help_text)s</td></tr>',
            error_row='<tr><td colspan="2">%s</td></tr>',
            row_ender='</td></tr>',
            help_text_html='<br><span class="helptext">%s</span>',
            errors_on_separate_row=False,
         )

from django-locallibrary-tutorial.

Thanks @ahwebd . I hope to go through and do some fixes (including reviewing this) in the coming months. Appreciate you taking the time to post this.

from django-locallibrary-tutorial.

Thanks very much. This is now fixed. You're quite right about this.

from django-locallibrary-tutorial.